From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <johannes.goede@oss.qualcomm.com>
Cc: linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org,
stable@vger.kernel.org, Sergey Lebedev <lsa.uz@pm.me>
Subject: Re: [PATCH v3 1/2] Input: soc_button_array - fix MS Surface Pro 11 probe failure
Date: Sun, 13 Sep 2026 16:43:35 -0700 [thread overview]
Message-ID: <aqc1GgNdo-CccQpD@google.com> (raw)
In-Reply-To: <20260909093934.29411-1-johannes.goede@oss.qualcomm.com>
On Wed, Sep 09, 2026 at 11:39:33AM +0200, Hans de Goede wrote:
> On the MS Surface Pro 11 soc_button_array probing races with the GPIO
> driver probing. If soc_button_array wins the race then gpiod_get() returns
> EPROBE_DEFER, which should normally take care of retrying later, but
> the soc_button_array code deliberately ignores EPROBE_DEFER causing it
> to fail its probe() which causes the volume and power buttons to now work.
>
> The ignoring of EPROBE_DEFER is there to deal with a problem specific to
> older Bay Trail (BYT) and Cherry Trail (CHT) tablets which often use this
> driver. Modify the error handling to only ignore EPROBE_DEFER on BYT and
> CHT platforms and propagate EPROBE_DEFER normally on other platforms.
>
> Fixes: bcf059578980 ("Input: soc_button_array - partial revert of support for newer surface devices")
> Cc: stable@vger.kernel.org
> Reported-by: Sergey Lebedev <lsa.uz@pm.me>
> Closes: https://lore.kernel.org/lkml/20260830141355.55898-1-lsa.uz@pm.me/
> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Applied the lot, thank you.
--
Dmitry
prev parent reply other threads:[~2026-09-13 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 9:39 [PATCH v3 1/2] Input: soc_button_array - fix MS Surface Pro 11 probe failure Hans de Goede
2026-09-09 9:39 ` [PATCH v3 2/2] Input: soc_button_array - check btns_desc->package.count Hans de Goede
2026-09-09 10:25 ` [PATCH v3 1/2] Input: soc_button_array - fix MS Surface Pro 11 probe failure Sergey Lebedev
2026-09-10 8:43 ` Hans de Goede
2026-09-13 23:43 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqc1GgNdo-CccQpD@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=johannes.goede@oss.qualcomm.com \
--cc=linux-input@vger.kernel.org \
--cc=lsa.uz@pm.me \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox