Re: [PATCH v8 12/20] drm/xe/vsec: Update VSEC probe order

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Sep 11, 2026 at 01:12:00PM -0700, Michael J. Ruhl wrote:
> Both debugfs and hwmon access the PMT data area before PMT is
> initialized.
> 
> Hardwired offset usage allows this to work by accident.
> Upcoming changes will break this usage.
> 
> Re-order the probe steps to initialize VSEC before the other
> features are initialized.
> 
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

(Apparently this is the cause of Sashiko's race finding on patch 17...)

> ---
>  drivers/gpu/drm/xe/xe_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 205cb4e7f9e8..3ec950606e67 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -1053,6 +1053,8 @@ int xe_device_probe(struct xe_device *xe)
>  	if (err)
>  		goto err_unregister_display;
>  
> +	xe_vsec_init(xe);
> +
>  	xe_debugfs_register(xe);
>  
>  	err = xe_hwmon_register(xe);
> @@ -1066,8 +1068,6 @@ int xe_device_probe(struct xe_device *xe)
>  	for_each_gt(gt, xe, id)
>  		xe_gt_sanitize_freq(gt);
>  
> -	xe_vsec_init(xe);
> -
>  	err = xe_sriov_init_late(xe);
>  	if (err)
>  		goto err_unregister_display;
> -- 
> 2.43.0
>