From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CB6C77B7A for ; Tue, 6 Jun 2023 09:24:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237451AbjFFJYA (ORCPT ); Tue, 6 Jun 2023 05:24:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236496AbjFFJX7 (ORCPT ); Tue, 6 Jun 2023 05:23:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 188EAE51 for ; Tue, 6 Jun 2023 02:23:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686043397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/HBlyIZo7CdZJvTEe5U8mNT5oLotniCeKkm4ow0MrE=; b=A7XK+QT1qBGpYgiCV1Nd9H1pdwkuNyG7M64nX2Miz0PnggGhnmtTLspuO3VYDTspPtSFXd Z/Eqt2nVzseYg/R2uAVnvM1/WNp9uety77jXQWIOj2ZUM9hVKoRjQxLC9lzPLL5CYFEOKW rm6SO59z+5w719o1FWtkpBee80MDvQg= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-533-jjBvKcsHPXqlPCK1ozkPzQ-1; Tue, 06 Jun 2023 05:23:16 -0400 X-MC-Unique: jjBvKcsHPXqlPCK1ozkPzQ-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-514559574a9so7969024a12.1 for ; Tue, 06 Jun 2023 02:23:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686043395; x=1688635395; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R/HBlyIZo7CdZJvTEe5U8mNT5oLotniCeKkm4ow0MrE=; b=FOxyEp6lF2pI1Af+jPy2HkB3P21ZvX0YcsH6pq0HpgaYyZ0B6Z9d3muN+frqf9Vnas QjG1C6voyoOHwFCEGdqh9FGvAADfV5j0LvrsKxAun7JB6MOQTFv+076DBy9n7Y6ur5wG Pg+mUcZ6eyTVdfP8Lq5NqDlJqWrE+G5YQltL5wcYuw8/QWY0jrsNUXxiOBkCBHWII1GC zbD7Xrg+dtBiw2mekCJ7sEOr9Fq9UySRw54dQtMC0+DR90TMm+UO4+oJNk8LAP7MQgf+ 8IBsOX7rhrcv8Ag9B8L/7s16rkiMrrapT7z49cXCuYATJ9WBE8FKlY1olgpA/i8uGgwY UiMQ== X-Gm-Message-State: AC+VfDzsOHnm2Zj750xp8p6RJKVVCJLRmHzGUUd/TAd9DNESw4Ra/lnM TPx9MVxgpV8HBw+DUsCeuy7ERbFlf0UT2ffIf1W+p99P1HkR7nExUrELU1flQ7SpvZIFfi3m+LQ utVBxqT1O+WdZawl+AneGrXoR2GlPG1HKVg== X-Received: by 2002:a05:6402:184d:b0:50b:7959:8b09 with SMTP id v13-20020a056402184d00b0050b79598b09mr1875670edy.15.1686043395038; Tue, 06 Jun 2023 02:23:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ46s7yTl/UNP/gNkpOIeOGPXLeufV6GWS8Htq/ljAFSEZIUwDKqXD2mSEd+vMpuxHNg+WehKg== X-Received: by 2002:a05:6402:184d:b0:50b:7959:8b09 with SMTP id v13-20020a056402184d00b0050b79598b09mr1875652edy.15.1686043394744; Tue, 06 Jun 2023 02:23:14 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id be21-20020a0564021a3500b00514b0f6a75esm4711432edb.97.2023.06.06.02.23.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jun 2023 02:23:14 -0700 (PDT) Message-ID: Date: Tue, 6 Jun 2023 11:23:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2] platform/x86: int3472: Evaluate device's _DSM method to control imaging clock Content-Language: en-US, nl To: Andy Shevchenko Cc: =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , Andy Shevchenko , Daniel Scally , Daniel Scally , bingbu.cao@linux.intel.com, platform-driver-x86@vger.kernel.org, Sakari Ailus , linux-media@vger.kernel.org, Bingbu Cao , Hao Yao References: <20230531134429.171337-1-hdegoede@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org HI, On 5/31/23 19:56, Andy Shevchenko wrote: > On Wed, May 31, 2023 at 4:44 PM Hans de Goede wrote: >> >> From: Bingbu Cao >> >> On some platforms, the imaging clock should be controlled by evaluating >> specific clock device's _DSM method instead of setting gpio, so this >> change register clock if no gpio based clock and then use the _DSM method >> to enable and disable clock. > > ... > >> + if (clk->ena_gpio) >> + gpiod_set_value_cansleep(clk->ena_gpio, 1); >> + else >> + skl_int3472_enable_clk_acpi_method(clk, 1); > > Looking at this, can we avoid duplicative validation of the GPIO? > Perhaps skl_int3472_enable_clk_acpi_method() can have embedded another > check so they won't be called together? > > ... > >> + if (clk->ena_gpio) >> + gpiod_set_value_cansleep(clk->ena_gpio, 0); >> + else >> + skl_int3472_enable_clk_acpi_method(clk, 0); > > Ditto. Ack, I've squashed a fix for this into this patch while merging it into my review-hans branch. Regards, Hans