Re: [PATCH v2 3/3] platform/x86: hp-bioscfg: Fix automatic module loading

[Mario Limonciello <mario.limonciello@amd.com>]

On 1/18/2026 4:51 AM, Armin Wolf wrote:
> Am 15.01.26 um 21:31 schrieb Mario Limonciello:
> 
>> hp-bioscfg has a MODULE_DEVICE_TABLE with a GUID in it that looks
>> plausible, but the module doesn't automatically load on applicable
>> systems.
>>
>> This is because the GUID has some lower case characters and so it
>> doesn't match the modalias during boot. Update the GUIDs to be all
>> uppercase.
> 
> Hi,
> 
> this is the second time that such a error has prevented a WMI driver from
> being loaded manually. I am planning to replace the usage of GUID strings
> with the guid_t data type in the future, but for now i think modifying
> file2alias.c to fixup any lowercase letters inside a GUID string will
> prevent such errors.
> 
> I will send the necessary patch once the WMI marshalling series has landed
> upstream. 

That's great to hear, thanks for sharing.

Thanks for finding this hard to spot error.

Sure.  I was really surprised it existed since the beginning of this 
driver.  That (unfortunately) means that very few people have been using it.

> 
> Thanks,
> Armin Wolf
> 
>> Cc: stable@vger.kernel.org
>> Fixes: 5f94f181ca25 ("platform/x86: hp-bioscfg: bioscfg-h")
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.h b/drivers/ 
>> platform/x86/hp/hp-bioscfg/bioscfg.h
>> index 6b6748e4be21..f1eec0e4ba07 100644
>> --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.h
>> +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.h
>> @@ -57,14 +57,14 @@ enum mechanism_values {
>>   #define PASSWD_MECHANISM_TYPES "password"
>> -#define HP_WMI_BIOS_GUID        "5FB7F034-2C63-45e9-BE91-3D44E2C707E4"
>> +#define HP_WMI_BIOS_GUID        "5FB7F034-2C63-45E9-BE91-3D44E2C707E4"
>> -#define HP_WMI_BIOS_STRING_GUID        "988D08E3-68F4-4c35- 
>> AF3E-6A1B8106F83C"
>> +#define HP_WMI_BIOS_STRING_GUID        "988D08E3-68F4-4C35- 
>> AF3E-6A1B8106F83C"
>>   #define HP_WMI_BIOS_INTEGER_GUID    "8232DE3D-663D-4327-A8F4- 
>> E293ADB9BF05"
>>   #define HP_WMI_BIOS_ENUMERATION_GUID    "2D114B49-2DFB-4130- 
>> B8FE-4A3C09E75133"
>>   #define HP_WMI_BIOS_ORDERED_LIST_GUID    "14EA9746-CE1F-4098- 
>> A0E0-7045CB4DA745"
>>   #define HP_WMI_BIOS_PASSWORD_GUID    
>> "322F2028-0F84-4901-988E-015176049E2D"
>> -#define HP_WMI_SET_BIOS_SETTING_GUID    "1F4C91EB-DC5C-460b-951D- 
>> C7CB9B4B8D5E"
>> +#define HP_WMI_SET_BIOS_SETTING_GUID    "1F4C91EB-DC5C-460B-951D- 
>> C7CB9B4B8D5E"
>>   enum hp_wmi_spm_commandtype {
>>       HPWMI_SECUREPLATFORM_GET_STATE  = 0x10,