From: Hans de Goede <hdegoede@redhat.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>, mgross@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 0/6] updates to amd-pmc driver
Date: Tue, 22 Jun 2021 15:28:23 +0200 [thread overview]
Message-ID: <b720bcaa-3b6f-2727-2159-a2bee82faeff@redhat.com> (raw)
In-Reply-To: <20210617113040.1603970-1-Shyam-sundar.S-k@amd.com>
Hi,
On 6/17/21 1:30 PM, Shyam Sundar S K wrote:
> Couple of existing issues on the completion codes to SMU
> and a newer way to get the s0ix statistics are introduced.
>
> Also, add acpi ids for current and future revisions of the
> pmc controller.
>
> Shyam Sundar S K (6):
> platform/x86: amd-pmc: Fix command completion code
> platform/x86: amd-pmc: Fix SMU firmware reporting mechanism
> platform/x86: amd-pmc: Add support for logging SMU metrics
> platform/x86: amd-pmc: Add support for logging s0ix counters
> platform/x86: amd-pmc: Add support for ACPI ID AMDI0006
> platform/x86: amd-pmc: Add new acpi id for future PMC controllers
Thanks, other then my remarks on patch 2/6, the rest of
the series looks good to me, so you may add my:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
To patches 1/6 and [3-6]/6 .
Regards,
Hans
prev parent reply other threads:[~2021-06-22 13:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 11:30 [PATCH 0/6] updates to amd-pmc driver Shyam Sundar S K
2021-06-17 11:30 ` [PATCH 1/6] platform/x86: amd-pmc: Fix command completion code Shyam Sundar S K
2021-06-17 14:59 ` Hans de Goede
2021-06-23 19:59 ` Raul E Rangel
2021-06-17 11:30 ` [PATCH 2/6] platform/x86: amd-pmc: Fix SMU firmware reporting mechanism Shyam Sundar S K
2021-06-17 15:02 ` Hans de Goede
2021-06-17 16:56 ` Limonciello, Mario
2021-06-17 17:31 ` Hans de Goede
2021-06-20 16:47 ` Shyam Sundar S K
2021-06-17 11:30 ` [PATCH 3/6] platform/x86: amd-pmc: Add support for logging SMU metrics Shyam Sundar S K
2021-06-17 11:30 ` [PATCH 4/6] platform/x86: amd-pmc: Add support for logging s0ix counters Shyam Sundar S K
2021-06-17 11:30 ` [PATCH 5/6] platform/x86: amd-pmc: Add support for ACPI ID AMDI0006 Shyam Sundar S K
2021-06-17 11:30 ` [PATCH 6/6] platform/x86: amd-pmc: Add new acpi id for future PMC controllers Shyam Sundar S K
2021-06-22 13:28 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b720bcaa-3b6f-2727-2159-a2bee82faeff@redhat.com \
--to=hdegoede@redhat.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox