Re: [PATCH] platform/x86: int3472: Add strobe GPIO function

[Hao Yao <hao.yao@intel.com>]

Thank you Andy,

On 2023/10/7 16:22, Andy Shevchenko wrote:
> On Sat, Oct 07, 2023 at 10:13:09AM +0800, Hao Yao wrote:
>> Strobe pin is used for Lattice MIPI aggregator to control the LED
>> so it can be handled together with privacy LED.
> 
> Thinking about this more, I am not now sure that this is a good approach.
> The idea behind the STROBE LED is that is used for flash light and should
> not be like on/off state, but rather the (quite) short pulse.
> 
> Combining these two together may even overheat the real strobe LED if used.

I agree. If the GPIO is used for a real flash LED, is it better to 
develop a new driver to control it. For example, some cameras need a 
flashlight device "LM3643".

> That said, is that platform using strobe GPIO for the privacy LED for real?!

On my Meteor Lake device, this pin is used for IR camera so actually it 
should control the IR LED. However I still don't know its detail usage. 
It may depends on the Lattice firmware, because I found only the 
handshake pin takes effects now and can't do more experiments. I think 
we should leave it open and I will update when I find something new.