Re: [PATCH] platform/x86: hp-wmi: Add support for home in HP OMEN laptops

[Dana Goyette <danagoyette@gmail.com>]

On 9/26/20 3:47 AM, Hans de Goede wrote:>
> So after looking at:
>
 > 
http://s3.amazonaws.com/digitaltrends-uploads-prod/2017/09/HP-Omen-15-review-keyboard-2.jpg 

>
>
> I understand what you mean with "where home key should be". So I've been
> thinking
> a bit about what is the best thing to do here. Arguably mapping it to
> KEY_CONTROLPANEL would be more accurate. But I can completely understand
> how
> you just want to have a working "home" key; and it indeed is in the place
> where on HP laptop keyboards with a num-pad, you would expect the > home key.
>
> So lets just map it to KEY_HOME as you suggest:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Regards,
>
> Hans
>
>
>

FYI, the HP Omen 15 2020 has a different keyboard, where Home is a 
proper separate key.  The India model has yet another layout, with a 
full numeric keypad that also includes Home.  So unless we want to get 
into DMI matching, it's safest to map the key to something distinct.

Layout on the US model:

[Omen]   [Calc] [PrtScr]
[Insert] [Home] [PgUp]
[Pause]  [End]  [PgDn]

Layout on the India model:
[Omen]    [Calc] [Insert] [PrtScr]
[NumLock] [/]    [*]      [-]
[7/Home]  [8]    [9/PgUp] [+]

(Where's Delete?  Above Backspace.)