From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A82C433EF for ; Tue, 12 Oct 2021 15:54:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF6B46103D for ; Tue, 12 Oct 2021 15:54:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237494AbhJLP4x (ORCPT ); Tue, 12 Oct 2021 11:56:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60372 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237476AbhJLP4v (ORCPT ); Tue, 12 Oct 2021 11:56:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634054089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CKcfhdVqfkpd0KNcl7uSyc4SWQzXE5GXNGJiUf3+7ao=; b=YjtykSVIwVFfjMVS6y1zamGdbWk6bt6qbozkvy3TzxqTsiVNo0kTQwEjaFja6/RORAhLnt h7WmRucFB0cvaGcJRZT4Sx61Q+WO1bA+RrjLZ3Zh8F1Ocyk9OdXHjAU8tdUA3a/vQlQSFY va5oQuyRJWR4PyUfDJKgGcgwYyexLmA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-72-NRbZ1sclPY2LBAaFq2pAZw-1; Tue, 12 Oct 2021 11:54:48 -0400 X-MC-Unique: NRbZ1sclPY2LBAaFq2pAZw-1 Received: by mail-ed1-f70.google.com with SMTP id p20-20020a50cd94000000b003db23619472so288487edi.19 for ; Tue, 12 Oct 2021 08:54:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CKcfhdVqfkpd0KNcl7uSyc4SWQzXE5GXNGJiUf3+7ao=; b=u8BQ5RjKqCT0P0nzr4KGqKq4BHyZennwJPLu0COrH2U4zeITBvY3oFYXsPIk+efIJg WB4AqCRokjjQ0h8u9iKsg53ogmMTsW4MAM77bKdhIdigSS4xtgaOho06ErNpQ1MCsUWW DChOCo2TBcI0f4YAF14naVoMhgJlN5mmJPRCXKSemHiS8yCiUu48JFgnttB5747gbDuY p8z6o9Ch37yDlOFo8PgjZn8KCvcDMCKxufyk7LRv2n9qNoA+7tTvl5yNer+sh/ywVGTQ 8zjMR4YoZbJkqGLQOzVd8lECgnTc7mM05zvoUJ4nIZBmvxAgdDBvmGYmbKpUYI/rY4BZ 68Wg== X-Gm-Message-State: AOAM533HDg1DgVQvL5TkedTAScJv6WqbUxOHJc4wMMGWttXMPDasOjS5 X8g7HYK1uhh6zIK3LEq32dhHKp3wGuIMha+GkDjvimNk0ne3c3BJZPK7uLWsedMlvKuVI0U/oVi TpEc76z4VwWwWvAVVrdAGE6lyLmVW4B4isp4uY3XF4XnR+MAZquV+bUOxy82lGMbs3Mf136BJqr 9z/PAz0As0iQ== X-Received: by 2002:a17:906:1bf2:: with SMTP id t18mr19670033ejg.340.1634054087309; Tue, 12 Oct 2021 08:54:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPqbgLk1hBABtjOounE1ddW9bk4p3yz3ex1QkxmBw4gZ2oNtmsKSacA/Yyvw8HUjRH65UtBg== X-Received: by 2002:a17:906:1bf2:: with SMTP id t18mr19670002ejg.340.1634054087072; Tue, 12 Oct 2021 08:54:47 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id g26sm2340336ejb.84.2021.10.12.08.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Oct 2021 08:54:46 -0700 (PDT) Subject: Re: [PATCH v2 12/20] misc: lis3lv02d: Make lis3lv02d_remove_fs() return void To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Arnd Bergmann , Eric Piel , Greg Kroah-Hartman , Mark Gross Cc: Mark Brown , kernel@pengutronix.de, linux-spi@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20211012153945.2651412-1-u.kleine-koenig@pengutronix.de> <20211012153945.2651412-13-u.kleine-koenig@pengutronix.de> From: Hans de Goede Message-ID: Date: Tue, 12 Oct 2021 17:54:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211012153945.2651412-13-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 10/12/21 5:39 PM, Uwe Kleine-König wrote: > Up to now lis3lv02d_remove_fs() returns zero unconditionally. Make it return > void instead which makes it easier to see in the callers that there is > no error to handle. > > Also the return value of i2c and spi remove callbacks is ignored anyway. > > Signed-off-by: Uwe Kleine-König Thanks, patch looks good to me: Reviewed-by: Hans de Goede Also please consider this as my ack for merging the drivers/platform/x86/ part of this through whatever tree is convenient. Regards, Hans > --- > drivers/misc/lis3lv02d/lis3lv02d.c | 3 +-- > drivers/misc/lis3lv02d/lis3lv02d.h | 2 +- > drivers/misc/lis3lv02d/lis3lv02d_spi.c | 4 +++- > drivers/platform/x86/hp_accel.c | 3 ++- > 4 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/misc/lis3lv02d/lis3lv02d.c b/drivers/misc/lis3lv02d/lis3lv02d.c > index 70c5bb1e6f49..3a7808b796b1 100644 > --- a/drivers/misc/lis3lv02d/lis3lv02d.c > +++ b/drivers/misc/lis3lv02d/lis3lv02d.c > @@ -878,7 +878,7 @@ static int lis3lv02d_add_fs(struct lis3lv02d *lis3) > return sysfs_create_group(&lis3->pdev->dev.kobj, &lis3lv02d_attribute_group); > } > > -int lis3lv02d_remove_fs(struct lis3lv02d *lis3) > +void lis3lv02d_remove_fs(struct lis3lv02d *lis3) > { > sysfs_remove_group(&lis3->pdev->dev.kobj, &lis3lv02d_attribute_group); > platform_device_unregister(lis3->pdev); > @@ -894,7 +894,6 @@ int lis3lv02d_remove_fs(struct lis3lv02d *lis3) > pm_runtime_set_suspended(lis3->pm_dev); > } > kfree(lis3->reg_cache); > - return 0; > } > EXPORT_SYMBOL_GPL(lis3lv02d_remove_fs); > > diff --git a/drivers/misc/lis3lv02d/lis3lv02d.h b/drivers/misc/lis3lv02d/lis3lv02d.h > index c394c0b08519..195bd2fd2eb5 100644 > --- a/drivers/misc/lis3lv02d/lis3lv02d.h > +++ b/drivers/misc/lis3lv02d/lis3lv02d.h > @@ -312,7 +312,7 @@ int lis3lv02d_joystick_enable(struct lis3lv02d *lis3); > void lis3lv02d_joystick_disable(struct lis3lv02d *lis3); > void lis3lv02d_poweroff(struct lis3lv02d *lis3); > int lis3lv02d_poweron(struct lis3lv02d *lis3); > -int lis3lv02d_remove_fs(struct lis3lv02d *lis3); > +void lis3lv02d_remove_fs(struct lis3lv02d *lis3); > int lis3lv02d_init_dt(struct lis3lv02d *lis3); > > extern struct lis3lv02d lis3_dev; > diff --git a/drivers/misc/lis3lv02d/lis3lv02d_spi.c b/drivers/misc/lis3lv02d/lis3lv02d_spi.c > index f664ed123730..9e40dfb60742 100644 > --- a/drivers/misc/lis3lv02d/lis3lv02d_spi.c > +++ b/drivers/misc/lis3lv02d/lis3lv02d_spi.c > @@ -102,7 +102,9 @@ static int lis302dl_spi_remove(struct spi_device *spi) > lis3lv02d_joystick_disable(lis3); > lis3lv02d_poweroff(lis3); > > - return lis3lv02d_remove_fs(&lis3_dev); > + lis3lv02d_remove_fs(&lis3_dev); > + > + return 0; > } > > #ifdef CONFIG_PM_SLEEP > diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c > index cc53f725c041..b183967ecfb7 100644 > --- a/drivers/platform/x86/hp_accel.c > +++ b/drivers/platform/x86/hp_accel.c > @@ -349,7 +349,8 @@ static int lis3lv02d_remove(struct platform_device *device) > led_classdev_unregister(&hpled_led.led_classdev); > flush_work(&hpled_led.work); > > - return lis3lv02d_remove_fs(&lis3_dev); > + lis3lv02d_remove_fs(&lis3_dev); > + return 0; > } > > #ifdef CONFIG_PM_SLEEP >