From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Alex Deucher <Alexander.Deucher@amd.com>
Subject: Re: [PATCH v2] platform/x86: amd-pmc: Add AMD platform support for S2Idle
Date: Wed, 4 Nov 2020 21:04:34 +0530 [thread overview]
Message-ID: <bdcba6b8-85b3-9257-a3c8-9fa711aaa780@amd.com> (raw)
In-Reply-To: <CAHp75VdzK_Uu5hrjSHbX_aRA9xOvcDhh91WNMx+3Ova6Y3jFig@mail.gmail.com>
Hi Andy,
On 11/4/2020 4:19 AM, Andy Shevchenko wrote:
> [CAUTION: External Email]
>
> On Thu, Oct 29, 2020 at 10:57 AM Shyam Sundar S K
> <Shyam-sundar.S-k@amd.com> wrote:
>>
>> AMD Power Management Controller driver aka. amd-pmc driver is the
>
> aka. -> a.k.a. or AKA
>
>> controller which is meant for final S2Idle transaction that goes to the
>
> for the final
>
>> PMFW running on the AMD SMU (System Management Unit) responsible for
>> tuning of the VDD.
>>
>> Once all the monitored list or the idle constraints are met, this driver
>> would go and set the OS_HINT (meaning all the devices have reached to
>> their lowest state possible) via the SMU mailboxes.
>>
>> This driver would also provide some debug capabilities via debugfs.
>
> ...
>
>> +F: drivers/platform/x86/amd-pmc.c
>> +F: drivers/platform/x86/amd-pmc.h
>
> Can be one entry.
>
I have addressed the comments. can you please review it again?
- Shyam
next prev parent reply other threads:[~2020-11-04 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 18:56 [PATCH v2] platform/x86: amd-pmc: Add AMD platform support for S2Idle Shyam Sundar S K
2020-11-03 12:28 ` Shyam Sundar S K
2020-11-03 13:04 ` Hans de Goede
2020-11-03 22:49 ` Andy Shevchenko
2020-11-04 15:34 ` Shyam Sundar S K [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-28 15:51 Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdcba6b8-85b3-9257-a3c8-9fa711aaa780@amd.com \
--to=shyam-sundar.s-k@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox