X86 platform drivers
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: "Benjamin Hasselgren-Hallén" <benjamin@benis.se>,
	"Kurt Borja" <kuurtb@gmail.com>
Cc: "platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Linux PM <linux-pm@vger.kernel.org>
Subject: Re: HP Omnibook Ultra Flip 14 - power profiles
Date: Mon, 30 Jun 2025 14:39:28 +0200	[thread overview]
Message-ID: <bf9475d3-9131-4d4f-af05-411fdd4f032f@gmx.de> (raw)
In-Reply-To: <oZxsMVf4IphclLjVLbrpp1rHYXlgWYV7BXDzgP40QKiHSOUtVDtDwP_s2uKFel3aLTZyIh-KepV7MjdSN_MkRWpn1_v55BEs0MEVyhKK0fU=@benis.se>

Am 30.06.25 um 14:32 schrieb Benjamin Hasselgren-Hallén:

>
>
>
> Best regards,
> Benjamin Hasselgren-Hallén
>
>
> On Saturday, 28 June 2025 at 02:45, Kurt Borja <kuurtb@gmail.com> wrote:
>
>> On Fri Jun 27, 2025 at 5:49 PM -03, Benjamin Hasselgren-Hallén wrote:
>>
>>> Hi Kurt,
>>>
>>> I do not experience the same error messages as in the bug report - no error message at all. It respons to changing power profile without any errors.
>>> I also tried 6.12 but same behaviour as 6.15.3 (just getting some gpu glitches - problably because of Lunar Lake).
>>
>> Can you paste the output of `cat /sys/firmware/acpi/platform_profile` on
>> Linux v6.12?
> cat /sys/firmware/acpi/platform_profile_choices
> cool quiet balanced performance
>
> cat /sys/firmware/acpi/platform_profile
> cat: /sys/firmware/acpi/platform_profile: Invalid argument

Good, it seems that the firmware returns additional data when querying the current platform profile.
As the driver does not mask-out this data, he cannot determine what kind of platform profile is currently
selected and thus returns -EINVAL.+

I can provide you with an experimental patch, could you test that?

Thanks,
Armin Wolf

>>> I am trying to understand how power profiles work - I guess on a high level it's controlled by uefi and the profile is set by the OS? Or is it more complicated than that?
>>
>> Yes, as quick overview. Power profiles are usually a capability of
>> individual devices. Drivers of these devices expose this profiles to
>> userspace through some predefined interfaces. Then your DE enviroment
>> exposes this to you.
>>
>> KDE and Gnome use power-profiles-daemon. This program controlls mainly
>> two kernel interfaces: CPUFreq and platform-profile (there may be more).
>>
>> You can read about CPUFreq here [1], although I don't know much about
>> it. The platform-profile interface may be used by any platform driver -
>> in your case this is the hp-wmi driver.
>>
>> This driver exposes some firmware defined profiles to sysfs trough the
>> following paths.
>>
>> /sys/firmware/acpi/
>> /sys/class/platform-profile/
>>
>> You won't find the latter in the Linux LTS version though. You will find
>> documentation on these paths here [2] and [3] respectively.
>>
>> PD: Please, avoid top-posting in kernel mailing lists, interleaved style
>> is very much preferred [4].
>>
>>
>> [1] https://docs.kernel.org/admin-guide/pm/cpufreq.html
>> [2] https://docs.kernel.org/admin-guide/abi-testing-files.html#abi-file-testing-sysfs-platform-profile
>> [3] https://docs.kernel.org/admin-guide/abi-testing-files.html#abi-file-testing-sysfs-class-platform-profile
>> [4] https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
>>
>> --
>> ~ Kurt

  reply	other threads:[~2025-06-30 12:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 13:52 HP Omnibook Ultra Flip 14 - power profiles Benjamin Hasselgren-Hallén
2025-06-23 18:52 ` Armin Wolf
2025-06-25  8:06   ` Benjamin Hasselgren-Hallén
2025-06-25 13:44     ` Armin Wolf
2025-06-25 21:22       ` Benjamin Hasselgren-Hallén
2025-06-25 21:43         ` Armin Wolf
2025-06-26 13:20           ` Benjamin Hasselgren-Hallén
2025-06-27 17:10             ` Armin Wolf
2025-06-27 19:15               ` Kurt Borja
2025-06-27 20:49                 ` Benjamin Hasselgren-Hallén
2025-06-27 21:56                   ` Benjamin Hasselgren-Hallén
2025-06-28  0:40                     ` Armin Wolf
2025-06-30 12:31                       ` Benjamin Hasselgren-Hallén
2025-06-28  0:45                   ` Kurt Borja
2025-06-30 12:32                     ` Benjamin Hasselgren-Hallén
2025-06-30 12:39                       ` Armin Wolf [this message]
2025-06-30 12:46                         ` Benjamin Hasselgren-Hallén
2025-06-30 14:49                           ` Armin Wolf
2025-06-30 22:29                             ` Benjamin Hasselgren-Hallén
2025-06-27 20:45               ` Benjamin Hasselgren-Hallén
2025-06-30  1:18               ` Zhang, Rui
2025-06-30 12:48                 ` Benjamin Hasselgren-Hallén
2025-06-30 13:23                   ` Benjamin Hasselgren-Hallén
2025-07-01  7:01                     ` Zhang, Rui
2025-07-01  7:44                       ` Benjamin Hasselgren-Hallén
     [not found]                         ` <1e02c8f28200d8e3f27589e0ba75a67f2e99d1a4.camel@intel.com>
     [not found]                           ` <Hsi54U41U6V6LB65SJ9b8D_q4OsW-xsvWJSQmvmxo7EfsebwJKc6NnNHLO20CerbcNGL-Q8huoeWtzNuGsCVNrQvJW8ndwTdnIKZJIDbTjg=@benis.se>
2025-07-15 21:21                             ` Benjamin Hasselgren-Hallén
     [not found]                             ` <4d0e07edfa83653fa8330e08fb4520f07bb38448.camel@intel.com>
2025-07-19 20:19                               ` Benjamin Hasselgren-Hallén
2025-07-19 20:38                                 ` Benjamin Hasselgren-Hallén
2025-07-23 21:18                                   ` Benjamin Hasselgren-Hallén
2025-07-01  6:54                   ` Zhang, Rui
2025-07-01  7:04                     ` Benjamin Hasselgren-Hallén
2025-07-02  1:13                       ` Zhang, Rui
2025-07-07 19:53                         ` Benjamin Hasselgren-Hallén

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf9475d3-9131-4d4f-af05-411fdd4f032f@gmx.de \
    --to=w_armin@gmx.de \
    --cc=benjamin@benis.se \
    --cc=daniel.lezcano@linaro.org \
    --cc=kuurtb@gmail.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox