[Bug 199715] hp_accel: probe of HPQ6007:00 failed with error -22 (HP Envy x360)

[bugzilla-daemon@bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=199715

--- Comment #55 from Richard Neumann (mail@richard-neumann.de) ---
@Dimitris. The submitted v8 Version of AMD is already merged into the mainline
kernel for v5.11, afaik. So we will definitely get a driver with kernel 5.11.
The only problem is, that it does not include an option to override the sensor
mask if the manufacturer of the system did not write it into the P2C register
as is the case on our HP Envy 13-ag0xxx models.
So the upstream driver is pretty useless to us.

My refactored patch series is a side-project I developed after the initial
driver version of AMD was submitted upstream. I repeatedly asked for adding a
kernel parameter to be able to override the sensor mask, which was confirmed as
a good idea, but was never implemented. So I took a look at the code myself and
added it. While I was at it, I encountered some more problems regarding the
code structure and DMA handling, that I also reported upstream [1]. I also saw
some unused code. So, to challenge myself to improve the driver, I read into
the Linux kernel API documentation for the HID subsystem, PCI drivers and
platform drivers and re-wrote the patch to what eventually became the patch
series that I now submitted upstream.

I understand Hans' concern about the rewrite, but I think that it would benefit
the Kernel to share my work on the driver. If the maintainers are reluctant to
replace the driver with my changes, that's okay. They can still cherry pick
what they regard as improvements on the code.

[1] https://lkml.org/lkml/2020/3/30/157

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.