[Bug 199715] hp_accel: probe of HPQ6007:00 failed with error -22 (HP Envy x360)

[bugzilla-daemon@bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=199715

--- Comment #30 from Richard Neumann (mail@richard-neumann.de) ---
@Hans Thank you for your input.

First, here is the requested output:

$ cat /etc/modprobe.d/amd_sfh.conf 
options amd_sfh_hid sensor_mask=524295

$ grep . /sys/class/dmi/id/* 2> /dev/null
/sys/class/dmi/id/bios_date:11/15/2019
/sys/class/dmi/id/bios_release:15.46
/sys/class/dmi/id/bios_vendor:AMI
/sys/class/dmi/id/bios_version:F.46
/sys/class/dmi/id/board_asset_tag:Base Board Asset Tag
/sys/class/dmi/id/board_name:8496
/sys/class/dmi/id/board_vendor:HP
/sys/class/dmi/id/board_version:92.48
/sys/class/dmi/id/chassis_type:31
/sys/class/dmi/id/chassis_vendor:HP
/sys/class/dmi/id/chassis_version:Chassis Version
/sys/class/dmi/id/ec_firmware_release:92.48
/sys/class/dmi/id/modalias:dmi:bvnAMI:bvrF.46:bd11/15/2019:br15.46:efr92.48:svnHP:pnHPENVYx360Convertible13-ag0xxx:pvr:rvnHP:rn8496:rvr92.48:cvnHP:ct31:cvrChassisVersion:
/sys/class/dmi/id/product_family:103C_5335KV HP Envy
/sys/class/dmi/id/product_name:HP ENVY x360 Convertible 13-ag0xxx
/sys/class/dmi/id/product_sku:4JS64EA#ABD
/sys/class/dmi/id/sys_vendor:HP
/sys/class/dmi/id/uevent:MODALIAS=dmi:bvnAMI:bvrF.46:bd11/15/2019:br15.46:efr92.48:svnHP:pnHPENVYx360Convertible13-ag0xxx:pvr:rvnHP:rn8496:rvr92.48:cvnHP:ct31:cvrChassisVersion:

Regarding the driver. Yes, it is completely refactored version that is close to
a re-write. I posted it to the IIO mailing list, since this is where the
original driver was also posted and discussed.
I realize that I made a lot of changes, but I am confident, that my code base
has a cleaner approach, since it utilizes the respective start, stop, open and
close functions of the HID LL API and contains less (if even any) unused code
and data structures. It is up to the maintainers whether they accept it,
request changes or whatnot. I've done my part and am happy using my clean and
stable implementation, that btw. is also used by other Arch Linux users with my
DKMS package in the AUR. I unsuccessfully tried to make changes to the upstream
driver during its development, which were ignored by both the devs and the
maintainers. Refactoring the driver to clean it up, make it integrate
seamlessly with the kernel APIs and providing the params to make it
configurable on devices where the manufacturers screwed up was challenging,
interesting and mostly a fun experience. Getting my work upstream, frankly, not
so much.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.