[Bug 199715] hp_accel: probe of HPQ6007:00 failed with error -22 (HP Envy x360)

[bugzilla-daemon@bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=199715

Hans de Goede (jwrdegoede@fedoraproject.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwrdegoede@fedoraproject.or
                   |                            |g

--- Comment #26 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Hi Richard,

Thank you for your work on this.

I took a look at your patch-series from 2:
https://patchwork.kernel.org/project/linux-iio/patch/efa4524cd07abe0a7773b24d33b64f09e0bf1f82.camel@richard-neumann.de/

And there are several big issues with it:

1) It seems to have only been send to the linux-iio mailing-list, while it
mostly touches files under drivers/hid. So the HID maintainers did not see it
and the iio maintainers are likely ignore it because it is not an IIO patch

2) You seem to have build an top of an older version of the amd-sfh driver and
instead of porting your changes to the new version, your series seems to
completely replace the currently upstream version with your version. A patch
series like this will never be accepted upstream. You need to submit a patch
upstream with a small incremental change on top of the upstream version of the
driver. E.g. submit a patch just adding the module parameter.

I've prepared a patch-set which adds a module parameter for the sensor-mask on
top of the current upstream version of the amd-sfh code, without making any
further changes. I'll attach that here, please test.

2 questions:

1. may I ask what sensor_mask_override value you are using? That will be useful
for Luya to test this on his device, as well as for adding a DMI quirk to
automatically do the right thing in the future.

2. Can you please run (as normal user):

grep . /sys/class/dmi/id/* 2> /dev/null

and copy and paste the output here?  We will need to come up with some way to
make this "just work" for end-users without needing to set the module-parameter
and it is likely that this will be based on a DMI quirk table, so it would be
good to have the DMI strings for your model.

Luya, I will build a Fedora kernel for you with the patches added. I will post
a link to that in the Fedora bug you filed for this; and Luya, can you also
provide the output of 'grep . /sys/class/dmi/id/* 2> /dev/null' please?

Regards,

Hans

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.