[Bug 204807] Hardware monitoring sensor nct6798d doesn't work unless acpi_enforce_resources=lax is enabled

bugzilla-daemon
2021-09-26T04:54:25Z

--- Comment #132 from Andy Shevchenko (andy.shevchenko@gmail.com) ---
(In reply to Denis Pauk from comment #131)
> (In reply to Eugene Shalygin from comment #129)
> > Thank you for your efforts to mainline these drivers! I have a couple of
> > changes and questions to the EC part. Is a review going on somewhere where
> I
> > can participate? Otherwise here are the main points:
> >
> I have not sent it to review yet. I prefer to have checked at least one
> motherboard from each group before send for review. Especially i2c adapter.

Don't forget to split per logical change (to me sounds like new code contains 3
to 5 logical pieces, hence the number of patches).

> (In reply to Kamil Pietrzak from comment #130)
> > Motherboard "TUF GAMING Z490-PLUS (WI-FI)" is using Nuvoton NCT6798D Super
> > I/O, so probably all motherboards that use same Nuvoton chip may benefit
> > from those new voltage scaling factors.
>
> What do you think about use kernel mode parameter for use custom value until
> we will have some approve that other motherboards with NCT6798D has same
> scale factors?

Once added, parameter may not be removed (because we don't break user space).
So, this parameter is not so critical and I am definitely against adding it.

The compromise would be to name after the tested board (with probably comment
in the commit message and/or the code that this is possible to have the same
for all NCT6789D chips) and when confirmed, rename as Kamil proposed.