X86 platform drivers
 help / color / mirror / Atom feed
From: bugzilla-daemon@kernel.org
To: platform-driver-x86@vger.kernel.org
Subject: [Bug 217947] WARNING at drivers/acpi/platform_profile.c:74 in platform_profile_show()
Date: Mon, 25 Sep 2023 12:54:13 +0000	[thread overview]
Message-ID: <bug-217947-215701-Pi7Dpbf8ny@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-217947-215701@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=217947

--- Comment #2 from Mark Pearson (mpearson-lenovo@squebb.ca) ---
Hi,

Can I confirm this is on a T14s G3 AMD platform?

Thanks for the detailed report - very helpful and very much appreciated. I'll
need to reproduce this but I don't have one of these platforms myself so will
need to ask a colleague for help.

It looks like this line is causing problems on this platform:
funcmode = (output >> DYTC_GET_FUNCTION_BIT) & 0xF;

Normally that should return PSC mode (in this case - unless you have AMT mode,
which you don't on that gen platform). 
But it's saying it is in standard mode instead....which is peculiar. The FW is
doing something non-standard to other platforms.

Do you still get the warning when:
 - you're in performance or low-power modes?
 - you're in lap mode?

As a quick test could you try adding:

 /* Check if we are PSC mode, or have AMT enabled */
 funcmode = (output >> DYTC_GET_FUNCTION_BIT) & 0xF;
+if (funcmode == DYTC_FUNCTION_STD)
+  funcmode = DYTC_FUNCTION_PSC;

To see if it behaves correctly please?

I'll have to check with the FW team and find out why this change in
behaviour...I suspect I need to do a kernel patch to better handle this AMT
case though.

Mark

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

  parent reply	other threads:[~2023-09-25 12:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25  9:12 [Bug 217947] New: WARNING at drivers/acpi/platform_profile.c:74 in platform_profile_show() bugzilla-daemon
2023-09-25  9:12 ` [Bug 217947] " bugzilla-daemon
2023-09-25 12:54 ` bugzilla-daemon [this message]
2023-09-26  6:54 ` bugzilla-daemon
2023-09-26  6:57 ` bugzilla-daemon
2023-09-26 10:32 ` bugzilla-daemon
2023-09-27  0:06 ` bugzilla-daemon
2023-09-27  6:34 ` bugzilla-daemon
2023-09-27 17:09 ` bugzilla-daemon
2023-09-28  6:10 ` bugzilla-daemon
2023-10-26  8:59 ` bugzilla-daemon
2023-10-26 17:21 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-217947-215701-Pi7Dpbf8ny@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox