[Bug 220566] New: Lenovo Ideapad laptops wrongly assign "Cut" intstead of "Selective_screenshot" to the corresponding hardware key

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=220566

            Bug ID: 220566
           Summary: Lenovo Ideapad laptops wrongly assign "Cut" intstead
                    of "Selective_screenshot" to the corresponding
                    hardware key
           Product: Drivers
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Platform_x86
          Assignee: drivers_platform_x86@kernel-bugs.osdl.org
          Reporter: tomashnyk@gmail.com
        Regression: No

Created attachment 308661
  --> https://bugzilla.kernel.org/attachment.cgi?id=308661&action=edit
The key in question

Lenovo ideapad laptops have a key (picture attached) that as per official
Lenovo documentation
(https://support.lenovo.com/au/en/documentation/SG10220/ref_hotkey_icons?language=en
) is supposed to mean this:

"Opens the Snipping tool. (Windows operating systems)"

Right now, as per line 1331 (
https://github.com/torvalds/linux/blob/master/drivers/platform/x86/lenovo/ideapad-laptop.c#L1331C1-L1332C1
) of linux/blob/master/drivers/platform/x86/lenovo/ideapad-laptop.c:

        { KE_KEY,   0x2d | IDEAPAD_WMI_KEY, { KEY_CUT } },

"Cut" is assigned (i.e. action usually triggered by CTRL+X).

I think your key is actually supposed to be Selective_screenshot (
https://github.com/torvalds/linux/blob/7aac71907bdea16e2754a782b9d9155449a9d49d/include/uapi/linux/input-event-codes.h#L675
) and is mislabeled.

Therefore the appropriate line should be:

        { KE_KEY,   0x2d | IDEAPAD_WMI_KEY, { KEY_SELECTIVE_SCREENSHOT } },

(note that on other Lenovo Laptops like for example some Thinkpads, this is
already used, even though the physical icon on the screenshot looks a bit
differently, see for example here:
https://download.lenovo.com//pccbbs/pubs/x1_extreme_p1_2nd_ug/html_en/index.html#t=en%2FUse_the_keyboard_shortcuts_(topic)_T0000709565.html&rhsearch=keyboard&rhhlterm=keyboard&rhsyns=%20
"Open the Snipping Tool program.")

It makes sense - this key is produced by pressing "FN+PRINT_SCREEN", so using
"Cut" for it is odd.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.