[Bug 221149] New: hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[Bug 221149] New: hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

            Bug ID: 221149
           Summary: hp-wmi: Fan control fails and RPM always reads as zero
                    on HP OMEN 16-wf1xxx (Board 8C76)
           Product: Drivers
           Version: 2.5
          Hardware: Intel
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Platform_x86
          Assignee: drivers_platform_x86@kernel-bugs.osdl.org
          Reporter: Jie7172585@gmail.com
        Regression: No

Created attachment 309484
  --> https://bugzilla.kernel.org/attachment.cgi?id=309484&action=edit
log of OMEN Gaming Hub

I am opening this new bug report to track the fan control issues for the HP
OMEN 16-wf1xxx (Board ID: 8C76)

The primary issue is that the manual fan control completely fails, and the fan
speed is always reported as zero. 

Description:
While the hp-wmi driver successfully exposes the hwmon nodes, attempting to
write to the pwm1_enable node (e.g., setting it to 0 for max fan speed) has no
physical effect on the fans. Furthermore, reading the fan speed (e.g., cat
fan1_input) constantly returns 0 RPM, even when the fans are physically
spinning under heavy CPU/GPU load. The commands seem to be rejected at the
firmware level.


Errors from dmesg:
The underlying WMI communication is failing, producing the following ACPI
errors in dmesg when trying to query/set thermal states:

hp_wmi: query 0x4c returned error 0x6
ACPI BIOS Error (bug): Attempt to CreateField of length zero
(20251212/dsopcode-133)
ACPI Error: Aborting method \_SB.WMID.WQBC due to previous error
(AE_AML_OPERAND_VALUE)
ACPI Error: Aborting method \_SB.WMID.WQBE due to previous error
(AE_AML_OPERAND_VALUE)
ACPI Error: Aborting method \_SB.WMID.WHCM due to previous error
(AE_AML_OPERAND_VALUE)
ACPI Error: Aborting method \_SB.WMID.WMAA due to previous error
(AE_AML_OPERAND_VALUE)


Hardware details:
  - Laptop: OMEN by HP Gaming Laptop 16-wf1xxx
  - DMI Board ID: 8C76
  - BIOS Version: F.15


EC dump:

$ sudo xxd /sys/kernel/debug/ec/ec0/io
00000000: 0000 0000 0001 48aa 0f84 fa71 0ffa 1c01  ......H....q....
00000010: 0129 251e ff00 ffff ffff ffff 00fa ac24  .)%............$
00000020: 0000 0000 0000 f900 350f 2000 0036 4b59  ........5. ..6KY
00000030: 5844 304b 3831 4a38 324a 5400 0100 00ff  XD0K81J82JT.....
00000040: ffff ff01 00ff ffff ff4c 494f 4e00 0000  .........LION...
00000050: 0009 ffff 3100 000f 4301 2d41 0000 0000  ....1...C.-A....
00000060: 0080 1620 3333 332d 4143 2d31 322d 4100  ... 333-AC-12-A.
00000070: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000080: 0000 0000 0b00 0000 0000 0000 0000 0000  ................
00000090: 3333 332d 4143 2d31 3257 4b30 3630 3833  333-AC-12WK06083
000000a0: 0001 00d8 4500 004c 0000 0008 642a 0078  ....E..L....d*.x
000000b0: 4d4d 3c5b 4100 3232 008c 0800 f242 1111  MM<[A.22.....B..
000000c0: 0000 7e1b 8505 0c32 3c2d 6c20 7e1b 6421  ..~....2<-l ~.d!
000000d0: 0000 0000 0000 7e1b bf02 5b11 0000 e000  ......~...[.....
000000e0: 0000 00af 10ad 10af 1000 0083 430b 0080  ............C...
000000f0: 0009 0200 0000 0000 5000 0061 580b 0000  ........P..aX...

I have attached the OMEN Gaming Hub logs from my Windows partition to this bug
report.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 221149] hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

Enderlava (Jie7172585@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Kernel Version|                            |7.0-rc1

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 221149] hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

Krishna Chomal (krishna.chomal108@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krishna.chomal108@gmail.com

--- Comment #1 from Krishna Chomal (krishna.chomal108@gmail.com) ---
Hi,

Based on the OGH log file from Windows, it is clear that your laptop uses the
newer Victus S style WMI interface.

Can you please test the following patch on the pdx86 tree?


diff --git a/drivers/platform/x86/hp/hp-wmi.c
b/drivers/platform/x86/hp/hp-wmi.c
index 304d9ac63c8a..aeed12f8a3d4 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -185,6 +185,10 @@ static const struct dmi_system_id
victus_s_thermal_profile_boards[] __initconst
                .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BD5") },
                .driver_data = (void *)&victus_s_thermal_params,
        },
+       {
+               .matches = { DMI_MATCH(DMI_BOARD_NAME, "8C76") },
+               .driver_data = (void *)&omen_v1_thermal_params,
+       },
        {
                .matches = { DMI_MATCH(DMI_BOARD_NAME, "8C78") },
                .driver_data = (void *)&omen_v1_thermal_params,


After loading the patched driver, please verify the following:

1. Check dmesg for successful registration message:
   "hp_wmi: Registered as platform profile handler"

2. Verify that fan RPM is readable and controllable via sysfs.

3. Verify that on changing platform profile, and it does physically change the
amount of power drawn in the CPU/GPU.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 221149] hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

Enderlava (Jie7172585@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Jie7172585@gmail.com

--- Comment #2 from Enderlava (Jie7172585@gmail.com) ---
Hi Krishna,

I successfully applied your patch to the 7.0-rc1 source and recompiled the
kernel. Here are the test results for Board 8C76:

1. Registration: success
`dmesg` shows `hp_wmi: Registered as platform profile handler`. The previous
ACPI/WMI errors (error 0x6) are completely gone.

2. Fan Control (Write): success
Writing 0 to `pwm1_enable` successfully ramps the fans to maximum speed, and
writing 2 returns them to auto mode. The physical fan control works perfectly.

3. Thermal Profile / Power Limits: success
Switching to the performance profile successfully raises the PL1 limit to 130W,
unlocking the CPU:
Profile: low-power    ->  PL1: 55 W  |  PL2: 130 W
Profile: balanced     ->  PL1: 55 W  |  PL2: 130 W
Profile: performance  ->  PL1: 130 W |  PL2: 130 W

4. Fan RPM Reading (Read): fails
Although the fans physically spin up and the control works, reading the hwmon
nodes (`cat fan1_input`) constantly returns 0 RPM.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 221149] hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

--- Comment #3 from Krishna Chomal (krishna.chomal108@gmail.com) ---
(In reply to Enderlava from comment #2)
> Hi Krishna,
> 
> I successfully applied your patch to the 7.0-rc1 source and recompiled the
> kernel. Here are the test results for Board 8C76:
> 
> 1. Registration: success
> `dmesg` shows `hp_wmi: Registered as platform profile handler`. The previous
> ACPI/WMI errors (error 0x6) are completely gone.
> 
> 2. Fan Control (Write): success
> Writing 0 to `pwm1_enable` successfully ramps the fans to maximum speed, and
> writing 2 returns them to auto mode. The physical fan control works
> perfectly.
> 
> 3. Thermal Profile / Power Limits: success
> Switching to the performance profile successfully raises the PL1 limit to
> 130W, unlocking the CPU:
> Profile: low-power    ->  PL1: 55 W  |  PL2: 130 W
> Profile: balanced     ->  PL1: 55 W  |  PL2: 130 W
> Profile: performance  ->  PL1: 130 W |  PL2: 130 W
> 

Great! I see that you tested AUTO and MAX fan modes, however with recent
improvements you can now use MANUAL mode as well by writing 1 to pwm1_enable
and using pwm1 file for the fan speed (0 being off and 255 being 100%), please
let me know if that works as well.

> 4. Fan RPM Reading (Read): fails
> Although the fans physically spin up and the control works, reading the
> hwmon nodes (`cat fan1_input`) constantly returns 0 RPM.

This is really strange, could you also try the below patch, read from
fan1_input (when you feel that the fans are spinning and the RPM should not be
0) and paste the dmesg logs.

# dmesg | grep hp_wmi

Thanks


diff --git a/drivers/platform/x86/hp/hp-wmi.c
b/drivers/platform/x86/hp/hp-wmi.c
index 304d9ac63c8a..e58c5f0dfe8e 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -185,6 +185,10 @@ static const struct dmi_system_id
victus_s_thermal_profile_boards[] __initconst
                .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BD5") },
                .driver_data = (void *)&victus_s_thermal_params,
        },
+       {
+               .matches = { DMI_MATCH(DMI_BOARD_NAME, "8C76") },
+               .driver_data = (void *)&omen_v1_thermal_params,
+       },
        {
                .matches = { DMI_MATCH(DMI_BOARD_NAME, "8C78") },
                .driver_data = (void *)&omen_v1_thermal_params,
@@ -621,9 +625,12 @@ static int hp_wmi_get_fan_speed_victus_s(int fan)
        ret = hp_wmi_perform_query(HPWMI_VICTUS_S_FAN_SPEED_GET_QUERY,
                                   HPWMI_GM, &fan_data, sizeof(u8),
                                   sizeof(fan_data));
-       if (ret != 0)
+       if (ret != 0) {
+               pr_info("[read] fan query failed with ret: %#x\n", ret);
                return -EINVAL;
+       }

+       pr_info("[read] fan_data: %*ph\n", (int)sizeof(fan_data), fan_data);
        return fan_data[fan] * 100;
 }

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 221149] hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

--- Comment #4 from Enderlava (Jie7172585@gmail.com) ---
I must apologize, the 0 RPM reading was my mistake. The RPM reading actually
works perfectly fine! There is just a slight normal delay in the EC updating
the value after the fans spin up. I re-tested it, and the RPM values are being
reported correctly.

Also, writing 1 to `pwm1_enable` works flawlessly, and adjusting `pwm1` from 0
to 255 scales the fan speed smoothly and exactly as expected.

Thank you so much for your fast and incredibly effective help!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 221149] hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

--- Comment #5 from Krishna Chomal (krishna.chomal108@gmail.com) ---
That's great! I am glad everything is working as intended.

I am preparing the final patch to send to the LKML, and would like to include
you in the 'Reported-by' and 'Tested-by' tags to credit your help with the
diagnostics and testing. Could you please provide the real name and email
address you would like me to use for these tags?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 221149] hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

--- Comment #6 from Enderlava (Jie7172585@gmail.com) ---
Please use the following details for the commit message:

Reported-by: WJ Enderlava <jie7172585@gmail.com>
Tested-by: WJ Enderlava <jie7172585@gmail.com>

Thank you again for your patch.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 221149] hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

--- Comment #7 from Krishna Chomal (krishna.chomal108@gmail.com) ---
I have submitted the patch to the maintainers. You can track its progress and
the mailing list discussion here:
https://lore.kernel.org/platform-driver-x86/20260227154106.226809-1-krishna.chomal108@gmail.com/

Thank you for your help :)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 221149] hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

--- Comment #8 from Krishna Chomal (krishna.chomal108@gmail.com) ---
Hi Enderlava,

The patch for this board has been merged into the mainline kernel. You can find
the commit here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=84d29bfd1929d08f092851162a3d055a2134d043

It should show up in the next release (likely 7.0 or a 6.x stable backport).
Since the patch is upstream, feel free to close this report as "Resolved
Fixed".

Thanks

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 221149] hp-wmi: Fan control fails and RPM always reads as zero on HP OMEN 16-wf1xxx (Board 8C76)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=221149

Randy Dunlap (rdunlap@infradead.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |rdunlap@infradead.org
         Resolution|---                         |CODE_FIX

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.