[Bug 221150] [BUG] hp-wmi: OMEN 16-k0xxx (board 8A4D) – verification of platform_profile and EC register behavior

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=221150

Krishna Chomal (krishna.chomal108@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krishna.chomal108@gmail.com

--- Comment #4 from Krishna Chomal (krishna.chomal108@gmail.com) ---
Hi,

Your board, 8A4D is not currently present in any whitelist in the hp-wmi
driver. As a result, it defaults to legacy Omen WMI interface to register the
platform-profile.

From your Omen Gaming Hub logs and EC dump, it is evident that your board
requires the newer Victus S style WMI queries for platform-profile switching
(and fan related activities), instead of the legacy queries.

Can you please apply the below patch and test the following:
1. Check dmesg for successful registration message:
   "hp_wmi: Registered as platform profile handler"

2. Verify that fan RPM is readable and controllable via sysfs
(/sys/devices/platform/hp-wmi/hwmon/*).

3. Verify that on changing platform profile, and it does physically change the
amount of power drawn in the CPU/GPU.



diff --git a/drivers/platform/x86/hp/hp-wmi.c
b/drivers/platform/x86/hp/hp-wmi.c
index 304d9ac63c8a..756b94ac4a35 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -120,6 +120,13 @@ static const struct thermal_profile_params
omen_v1_thermal_params = {
        .ec_tp_offset   = HP_VICTUS_S_EC_THERMAL_PROFILE_OFFSET,
 };

+static const struct thermal_profile_params omen_hybrid_thermal_params = {
+       .performance    = HP_OMEN_V1_THERMAL_PROFILE_PERFORMANCE,
+       .balanced       = HP_OMEN_V1_THERMAL_PROFILE_DEFAULT,
+       .low_power      = HP_OMEN_V1_THERMAL_PROFILE_DEFAULT,
+       .ec_tp_offset   = HP_OMEN_EC_THERMAL_PROFILE_OFFSET,
+};
+
 /*
  * A generic pointer for the currently-active board's thermal profile
  * parameters.
@@ -173,6 +180,10 @@ static const char * const victus_thermal_profile_boards[]
= {

 /* DMI Board names of Victus 16-r and Victus 16-s laptops */
 static const struct dmi_system_id victus_s_thermal_profile_boards[]
__initconst = {
+       {
+               .matches = { DMI_MATCH(DMI_BOARD_NAME, "8A4D") },
+               .driver_data = (void *)&omen_hybrid_thermal_params,
+       },
        {
                .matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
                .driver_data = (void *)&victus_s_thermal_params,

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.