Re: [PATCH] platform/x86/amd/pmc: Add Stellaris Slim Gen6 AMD to spurious 8042 quirks list

[Werner Sembach <wse@tuxedocomputers.com>]

Am 02.09.25 um 16:15 schrieb Mario Limonciello:
> On 9/1/2025 11:42 AM, Werner Sembach wrote:
>> From: Christoffer Sandberg <cs@tuxedo.de>
>>
>> Prevents instant wakeup ~1s after suspend
>>
>> Signed-off-by: Christoffer Sandberg <cs@tuxedo.de>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> ---
>>   drivers/platform/x86/amd/pmc/pmc-quirks.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c 
>> b/drivers/platform/x86/amd/pmc/pmc-quirks.c
>> index 7ffc659b27944..8b8944483b859 100644
>> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
>> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
>> @@ -248,6 +248,13 @@ static const struct dmi_system_id fwbug_list[] = {
>>               DMI_MATCH(DMI_PRODUCT_NAME, "Lafite Pro V 14M"),
>>           }
>>       },
>> +    {
>> +        .ident = "TUXEDO Stellaris Slim 15 AMD Gen6",
>> +        .driver_data = &quirk_spurious_8042,
>> +        .matches = {
>> +            DMI_MATCH(DMI_BOARD_NAME, "GMxHGxx"),
>> +        }
>> +    },
>>       {}
>>   };
>
> FYI - this seems to conflict with other changes on review-ilpo-fixes and fixes 
> branches.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/drivers/platform/x86/amd/pmc/pmc-quirks.c?h=review-ilpo-fixes&id=c96f86217bb28e019403bb8f59eacd8ad5a7ad1a 
>
Sorry, i will rebase and send a v2.
>
> Also - a few other comments.
>
> 1) Do you have line of sight to a firmware (BIOS or EC) fix?  If so; it would 
> be better to specify a specific firmware release that is affected.

No

@Christoffer you have more knowledge of how realistic it is to get this fixed by 
the odm?

But even then, we still don't have fwupd support to get the fw update out easily

>
> 2) Shouldn't you also have DMI_SYS_VENDOR or some other matching keys else 
> set?  Or is it really all these boards with this specific name?

I was following the style of the i8042 quirk list where we also always only did 
boardnames

Ofc we only tested the boards the odm has sent to us

best regards,

Werner Sembach