From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Hans de Goede <hansg@kernel.org>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: ISST: Correct locked bit width
Date: Tue, 17 Mar 2026 15:04:53 +0200 (EET) [thread overview]
Message-ID: <c3998aaa-75b5-bc03-ed7f-a82c0e6ea8cb@linux.intel.com> (raw)
In-Reply-To: <20260304214255.1748163-1-srinivas.pandruvada@linux.intel.com>
On Wed, 4 Mar 2026, Srinivas Pandruvada wrote:
> SST-PP locked bit width is set to three bits. It should be only one bit.
> Use SST_PP_LOCK_WIDTH define instead of SST_PP_LEVEL_WIDTH.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> index b8cdaa233ea9..fa1726185d44 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> @@ -869,7 +869,7 @@ static int isst_if_get_perf_level(void __user *argp)
> _read_pp_info("current_level", perf_level.current_level, SST_PP_STATUS_OFFSET,
> SST_PP_LEVEL_START, SST_PP_LEVEL_WIDTH, SST_MUL_FACTOR_NONE)
> _read_pp_info("locked", perf_level.locked, SST_PP_STATUS_OFFSET,
> - SST_PP_LOCK_START, SST_PP_LEVEL_WIDTH, SST_MUL_FACTOR_NONE)
> + SST_PP_LOCK_START, SST_PP_LOCK_WIDTH, SST_MUL_FACTOR_NONE)
Doesn't this warrant a Fixes tag?
--
i.
prev parent reply other threads:[~2026-03-17 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 21:42 [PATCH] platform/x86: ISST: Correct locked bit width Srinivas Pandruvada
2026-03-17 13:04 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3998aaa-75b5-bc03-ed7f-a82c0e6ea8cb@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox