From: Ivan Vecera <ivecera@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Vadim Pasternak <vadimp@mellanox.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"Bjørn Mork" <bjorn@mork.no>
Subject: Re: [PATCH v2] platform/x86: mlx-platform: fix module aliases
Date: Mon, 22 Jan 2018 15:17:50 +0100 [thread overview]
Message-ID: <c7478fd3-a77f-6ee3-674c-ef723f6cdc81@redhat.com> (raw)
In-Reply-To: <CAHp75Vd2us0ytvkoAxUeo-gb8Y6siSV2mfDZZeQGYkGU5-8Hnw@mail.gmail.com>
On 22.1.2018 12:48, Andy Shevchenko wrote:
> On Mon, Jan 22, 2018 at 12:23 PM, Vadim Pasternak <vadimp@mellanox.com> wrote:
>
>>> +MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);
>>
>> I am not sure about the location of MODULE_DEVICE_TABLE record.
>> Should it be placed at the end of the module or after mlxplat_dmi_table
>> declaration?
>
> Yeah, it would be better.
> I dunno if Darren is going to ask for another version or fix this
> manually when apply.
> To be on the safer side, send a v3 with properly attached line as
> Vadim suggested.
>
Will do.
Thanks,
I.
prev parent reply other threads:[~2018-01-22 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 10:11 [PATCH v2] platform/x86: mlx-platform: fix module aliases Ivan Vecera
2018-01-22 10:23 ` Vadim Pasternak
2018-01-22 11:48 ` Andy Shevchenko
2018-01-22 14:17 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7478fd3-a77f-6ee3-674c-ef723f6cdc81@redhat.com \
--to=ivecera@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=bjorn@mork.no \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox