From: Bryan O'Donoghue <bod@kernel.org>
To: "Sebastian Reichel" <sre@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] platform: arm64: thinkpad-t14s-ec: fix IRQ race condition
Date: Thu, 6 Nov 2025 01:40:22 +0000 [thread overview]
Message-ID: <cb0b090e-ce50-48d9-a90b-ffba3b22a49a@kernel.org> (raw)
In-Reply-To: <20251106-thinkpad-t14s-ec-improvements-v1-1-109548ae75c0@collabora.com>
On 05/11/2025 23:22, Sebastian Reichel wrote:
> Fix a race condition, that an input key related interrupt might be
> triggered before the input handler has been registered, which results
> in a NULL pointer dereference. This can happen if the user enables
> the keyboard backlight shortly before the driver is being probed.
>
> Fixes: 60b7ab6ce030 ("platform: arm64: thinkpad-t14s-ec: new driver")
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
Enabling interrupts late in probe seems like a bit of a no-brainer.
One thing though is the commit log might productively contain the
backtrace so that people can match bug fixes to specific backtraces.
Reviewed-by: Bryan O'Donoghue <bod@kernel.org>
next prev parent reply other threads:[~2025-11-06 1:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 23:22 [PATCH 0/4] platform: arm64: thinkpad-t14s-ec: fixes and suspend support Sebastian Reichel
2025-11-05 23:22 ` [PATCH 1/4] platform: arm64: thinkpad-t14s-ec: fix IRQ race condition Sebastian Reichel
2025-11-06 1:40 ` Bryan O'Donoghue [this message]
2025-11-05 23:22 ` [PATCH 2/4] platform: arm64: thinkpad-t14s-ec: sleep after EC access Sebastian Reichel
2025-11-05 23:22 ` [PATCH 3/4] platform: arm64: thinkpad-t14s-ec: add system PM hooks Sebastian Reichel
2025-11-06 12:07 ` Ilpo Järvinen
2025-11-05 23:22 ` [PATCH 4/4] platform: arm64: thinkpad-t14s-ec: add suspend handler for keyboard backlight Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb0b090e-ce50-48d9-a90b-ffba3b22a49a@kernel.org \
--to=bod@kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).