From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Subject: Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine Date: Fri, 11 Sep 2020 11:59:07 -0400 Message-ID: References: <20200905013107.10457-1-lszubowi@redhat.com> <20200905013107.10457-3-lszubowi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-security-module@vger.kernel.org To: Lenny Szubowicz , Ard Biesheuvel Cc: Linux Kernel Mailing List , linux-efi , platform-driver-x86@vger.kernel.org, linux-security-module@vger.kernel.org, andy.shevchenko@gmail.com, James Morris , serge@hallyn.com, Kees Cook , Borislav Petkov , Peter Jones , David Howells , prarit@redhat.com List-Id: platform-driver-x86.vger.kernel.org On Fri, 2020-09-11 at 11:54 -0400, Lenny Szubowicz wrote: > On 9/11/20 11:02 AM, Ard Biesheuvel wrote: > > On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz wrote: > >> > >> Move the loading of certs from the UEFI MokListRT into a separate > >> routine to facilitate additional MokList functionality. > >> > >> There is no visible functional change as a result of this patch. > >> Although the UEFI dbx certs are now loaded before the MokList certs, > >> they are loaded onto different key rings. So the order of the keys > >> on their respective key rings is the same. > >> > >> Signed-off-by: Lenny Szubowicz > > > > Why did you drop Mimi's reviewed-by from this patch? > > It was not intentional. I was just not aware that I needed to propagate > Mimi Zohar's reviewed-by from V1 of the patch to V2. > > Reviewed-by: Mimi Zohar > > V2 includes changes in that patch to incorporate suggestions from > Andy Shevchenko. My assumption was that the maintainer would > gather up the reviewed-by and add any signed-off-by as appropriate, > but it sounds like my assumption was incorrect. In retrospect, I > could see that having the maintainer dig through prior versions > of a patch set for prior reviewed-by tags could be burdensome. As much as possible moving code should be done without making changes, simpler for code review. Then as a separate patch you make changes. That way you could also have retained my Reviewed-by. Mimi > > Advice on the expected handling of this would be appreciated.