From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Sybil Isabel Dorsett <sybdorsett@proton.me>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Hans de Goede <hdegoede@redhat.com>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Fix invalid fan speed on ThinkPad X120e
Date: Mon, 3 Feb 2025 15:18:31 +0200 (EET) [thread overview]
Message-ID: <cc7c8e94-4340-3d1e-03b4-2f738067d24f@linux.intel.com> (raw)
In-Reply-To: <d20f933c-8041-bc8d-13c2-98d89ccfa524@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Mon, 3 Feb 2025, Ilpo Järvinen wrote:
> On Mon, 3 Feb 2025, Sybil Isabel Dorsett wrote:
>
> > On ThinkPad X120e, fan speed is incorrectly reported in ticks
>
> I'd drop "incorrectly".
>
> > per revolution rather than RPM.
> >
> > Recaculate the fan speed value reported for ThinkPad X120e
>
> Recalculate
>
> With those two changed, feel free to add:
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Err, you also need to add the correct prefix to the shortlog in the
subject, thanks.
--
i.
next prev parent reply other threads:[~2025-02-03 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 20:40 [PATCH] Fix invalid fan speed on ThinkPad X120e Sybil Isabel Dorsett
2025-02-03 9:07 ` Ilpo Järvinen
2025-02-03 13:03 ` [PATCH v2] " Sybil Isabel Dorsett
2025-02-03 13:16 ` Ilpo Järvinen
2025-02-03 13:18 ` Ilpo Järvinen [this message]
2025-02-03 16:33 ` [PATCH v3] platform/x86: thinkpad_acpi: " Sybil Isabel Dorsett
2025-02-10 14:57 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7c8e94-4340-3d1e-03b4-2f738067d24f@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sybdorsett@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox