Re: [PATCH v2 1/1] media: v4l2-subdev / pdx86: int3472: Use "privacy" as con_id for the privacy LED

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2076 bytes --]

On Wed, 10 Sep 2025, Hans de Goede wrote:

> During DT-binding review for extending the V4L2 camera sensor privacy LED
> support to systems using devicetree, it has come up that having a "-led"
> suffix for the LED name / con_id is undesirable since it already is clear
> that it is a LED.
> 
> Drop the "-led" suffix from the con_id in both the lookup table in
> the int3472 code, as well as from the con_id led_get() argument in
> the v4l2-subdev code.
> 
> Signed-off-by: Hans de Goede <hansg@kernel.org>
> ---
>  drivers/media/v4l2-core/v4l2-subdev.c    | 2 +-
>  drivers/platform/x86/intel/int3472/led.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index 113eb74eb7c1..babcc1120354 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -2602,7 +2602,7 @@ EXPORT_SYMBOL_GPL(v4l2_subdev_is_streaming);
>  int v4l2_subdev_get_privacy_led(struct v4l2_subdev *sd)
>  {
>  #if IS_REACHABLE(CONFIG_LEDS_CLASS)
> -	sd->privacy_led = led_get(sd->dev, "privacy-led");
> +	sd->privacy_led = led_get(sd->dev, "privacy");
>  	if (IS_ERR(sd->privacy_led) && PTR_ERR(sd->privacy_led) != -ENOENT)
>  		return dev_err_probe(sd->dev, PTR_ERR(sd->privacy_led),
>  				     "getting privacy LED\n");
> diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x86/intel/int3472/led.c
> index f1d6d7b0cb75..b1d84b968112 100644
> --- a/drivers/platform/x86/intel/int3472/led.c
> +++ b/drivers/platform/x86/intel/int3472/led.c
> @@ -43,7 +43,7 @@ int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gp
>  
>  	int3472->pled.lookup.provider = int3472->pled.name;
>  	int3472->pled.lookup.dev_id = int3472->sensor_name;
> -	int3472->pled.lookup.con_id = "privacy-led";
> +	int3472->pled.lookup.con_id = "privacy";
>  	led_add_lookup(&int3472->pled.lookup);
>  
>  	return 0;
> 

Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.