X86 platform drivers
 help / color / mirror / Atom feed
From: Suma Hegde <suma.hegde@amd.com>
To: <platform-driver-x86@vger.kernel.org>
Cc: <ilpo.jarvinen@linux.intel.com>, <Muthusamy.Ramalingam@amd.com>,
	<NaveenKrishna.Chatradhi@amd.com>, <Anand.Umarji@amd.com>,
	Suma Hegde <Suma.Hegde@amd.com>
Subject: [PATCH v2 00/11] platform/x86/amd/hsmp: Per-platform enabled-message bitmaps
Date: Thu, 19 Nov 2026 08:50:34 +0000	[thread overview]
Message-ID: <cover.1795061419.git.Suma.Hegde@amd.com> (raw)

From: Suma Hegde <Suma.Hegde@amd.com>

This series introduces per-socket read/write enabled-message bitmaps so
the HSMP driver rejects unsupported messages before they reach the SMU.
Prep patches fix sock_ind bounds checking, move proto_ver onto
hsmp_socket, and reorder helpers for the validation path. Later patches
populate the bitmaps statically and via HSMP_GET_ENABLED_HSMP_CMDS
(6th Gen AMD EPYC Server and future platforms), and update sysfs/hwmon
file modes from the bitmaps.

Client platforms skip bitmap init, populate, and validation until
dedicated client tables exist; shared smu_fw_version and
protocol_version sysfs attributes remain visible there.

Changes since v1:
- Named HSMP_MSG_BIT() static bitmaps; zen6 PQOS bits added and
  HSMP_SET_XGMI_PSTATE_RANGE dropped from the zen6 write bitmap.
- validate_message() runs only after sock->dev is ready.
- Safer dynamic bitmap fetch helpers and default-bitmap fallback.
- Skip hwmon registration on client platforms in the plat probe path.
- Keep the short client-attribute visibility comment in the modes patch.
- Commit message / tagging cleanups (Co-developed-by, defensive
  null-check wording, typos).
- See per-patch "Changes since v1" for details.

Patch summary:
  01/11  Fix sock_ind bounds check in hsmp_is_sock_attr_visible()
  02/11  Move proto_ver to hsmp_socket structure
  03/11  Null-check drvdata in hsmp_is_sock_attr_visible()
  04/11  Move is_get_msg() before validate_message()
  05/11  Use local sock pointer in init_acpi()
  06/11  Move the sock_ind bounds check before validate_message()
  07/11  Add per-platform bitmap to validate HSMP messages
  08/11  Populate the bitmaps dynamically on 6th Gen AMD EPYC Server
  09/11  Populate the bitmaps dynamically for future platforms
  10/11  Relocate to_hsmp_sys_attr() macro
  11/11  Update sysfs and hwmon file modes based on platform capabilities

Suma Hegde (11):
  platform/x86/amd/hsmp: Fix sock_ind bounds check in
    hsmp_is_sock_attr_visible()
  platform/x86/amd/hsmp: Move proto_ver to hsmp_socket structure
  platform/x86/amd/hsmp: Null-check drvdata in
    hsmp_is_sock_attr_visible()
  platform/x86/amd/hsmp: Move is_get_msg() before validate_message()
  platform/x86/amd/hsmp: Use local sock pointer in init_acpi()
  platform/x86/amd/hsmp: Move the sock_ind bounds check before
    validate_message()
  platform/x86/amd/hsmp: Add per-platform bitmap to validate HSMP
    messages
  platform/x86/amd/hsmp: Populate the bitmaps dynamically on 6th Gen AMD
    EPYC Server
  platform/x86/amd/hsmp: Populate the bitmaps dynamically for future
    platforms
  platform/x86/amd/hsmp: Relocate to_hsmp_sys_attr() macro
  platform/x86/amd/hsmp: Update sysfs and hwmon file modes based on
    platform capabilities

 drivers/platform/x86/amd/hsmp/acpi.c  |  94 +++++-
 drivers/platform/x86/amd/hsmp/hsmp.c  | 433 +++++++++++++++++++++++++-
 drivers/platform/x86/amd/hsmp/hsmp.h  |  29 +-
 drivers/platform/x86/amd/hsmp/hwmon.c |  24 +-
 drivers/platform/x86/amd/hsmp/plat.c  |  36 ++-
 5 files changed, 578 insertions(+), 38 deletions(-)


base-commit: c339f4010dea8b0d754f84ace70cd1b089878ef8
(rebased on platform-drivers-x86 master branch)
-- 
2.34.1


             reply	other threads:[~2026-11-19  8:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:50 Suma Hegde [this message]
2026-11-19  8:50 ` [PATCH v2 01/11] platform/x86/amd/hsmp: Fix sock_ind bounds check in hsmp_is_sock_attr_visible() Suma Hegde
2026-11-19  8:50 ` [PATCH v2 02/11] platform/x86/amd/hsmp: Move proto_ver to hsmp_socket structure Suma Hegde
2026-11-19  8:50 ` [PATCH v2 03/11] platform/x86/amd/hsmp: Null-check drvdata in hsmp_is_sock_attr_visible() Suma Hegde
2026-11-19  8:50 ` [PATCH v2 04/11] platform/x86/amd/hsmp: Move is_get_msg() before validate_message() Suma Hegde
2026-11-19  8:50 ` [PATCH v2 05/11] platform/x86/amd/hsmp: Use local sock pointer in init_acpi() Suma Hegde
2026-11-19  8:50 ` [PATCH v2 06/11] platform/x86/amd/hsmp: Move the sock_ind bounds check before validate_message() Suma Hegde
2026-11-19  8:50 ` [PATCH v2 07/11] platform/x86/amd/hsmp: Add per-platform bitmap to validate HSMP messages Suma Hegde
2026-11-19  8:50 ` [PATCH v2 08/11] platform/x86/amd/hsmp: Populate the bitmaps dynamically on 6th Gen AMD EPYC Server Suma Hegde
2026-11-19  8:50 ` [PATCH v2 09/11] platform/x86/amd/hsmp: Populate the bitmaps dynamically for future platforms Suma Hegde
2026-11-19  8:50 ` [PATCH v2 10/11] platform/x86/amd/hsmp: Relocate to_hsmp_sys_attr() macro Suma Hegde
2026-11-19  8:50 ` [PATCH v2 11/11] platform/x86/amd/hsmp: Update sysfs and hwmon file modes based on platform capabilities Suma Hegde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1795061419.git.Suma.Hegde@amd.com \
    --to=suma.hegde@amd.com \
    --cc=Anand.Umarji@amd.com \
    --cc=Muthusamy.Ramalingam@amd.com \
    --cc=NaveenKrishna.Chatradhi@amd.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox