From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C33322765C5 for ; Sun, 31 Aug 2025 23:53:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756684426; cv=none; b=Jslz2Xufs4SZeoO/ziIRCzn7QFZlrfSwm6+Jrkx0Ap+uw49rATVghJ4QtdXeDKqGcuYqrXWuRvlJJeqCV1Yn+kTobjDfZES88+hYrv5YFkX0HAjka9PhYH6DMCSlIfzc29UT5sqDMBzfyb3Xa3BXwHJMt5tmpL/MhatAoqN8cHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756684426; c=relaxed/simple; bh=XRMa5Nyj+EgloZQpXXnlKBtZMQtSW8HakSaIrjYylq0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CbT26a670HySkzUN2MZIVPwPXeeYeqU4PIS05BEemkXN3fH4sbj6EEhFexTXOcoTeOtVaADnTGRn1eXXy7THNJPbQcA1L37dFFgeg8VrigXOP0LG+1+1zObGp1jE9Sm77j/KlQfF+MQlYoS/lOj0nCOh7ywoO5UmNgRiJZrLZd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WyYY5Txf; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WyYY5Txf" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-affc2eb83c5so255879966b.2 for ; Sun, 31 Aug 2025 16:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756684423; x=1757289223; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SZzD5VUgp4Ev3IaBux7GJ+EciqXgORSO/NRjzJxU14E=; b=WyYY5TxfZD16+oQWcLRNZOp3lIFjfq+YJ8lojszzWE8stWRL8uXucw/MsdhtudYDko H5mH3OSLOfaPVRzBUotRXAxbhtrvzBIe68W90cRV3MDZ053vDnGTs9PGi+bLgwyATU5i 9QW2H2ZUsZNaYoiSXR2uYw1gltQ1QRDwfeq8wgJ5tQJtiJpbYpKdRB8aXNPms9JHvwtC heQ0/hUumb0DDvuO1RW99Lk6xf+MLuMsr5/jRA8dYRWjur9Nh9gZI1pkLqZv25wHjo7i /Q3eT3ZfE9e1nFWJ5Smk94GNF+a4mzau+2fK48SDuYeHnCQw1cnPeAz+LhWrLjgHC0JP 5swg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756684423; x=1757289223; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SZzD5VUgp4Ev3IaBux7GJ+EciqXgORSO/NRjzJxU14E=; b=NOqNXx7Kf+muJalvZKyYqmRpDhpyr5tlMjoWmxukF0j4FDg/RCNfVnT6LQ4RYBt+Sp ERLlYPSwicwNuE6osqG9w/mq2zvEO03eo3x3pTDiEr3esdvLRQLZ82qIpvawPiCynNGf ysAyluTxkpV5VcQNaawbr7fVXgoeTME0Vc3CUGQeKEnDBe5a2ChfiMEy1okT9iiSASjg emsL34sRu2opmGFa+gungxSGGsKHwhYwIn9xXcCdEFS+3XM+8hozp+P2F/8fdmWBGenV utqD8heg6oeCqBdzAnEJY9yryyA8q2Yo+64CdCwpznj9pn4oQIim1Nw6oPp0JhkM6Mfr S9vA== X-Forwarded-Encrypted: i=1; AJvYcCVFoFFE1Dl+pPcDYuJMbxA9e7v6i4wLujRVas/WHnLaEdCUxNXgy78k8DzIa4pwY9bir5REQO/2J5/3Su370gLaS7f+@vger.kernel.org X-Gm-Message-State: AOJu0YzonpU+JNr05nbg0K4Fp0IFfOLJE3NXYXiVtr569kDb7hEAKcbr Z65+ppn+9DB/8cF9dAWZLjFXEBTZc3Rj59PmLFj71kcNH2jVrgVz821Ad1uL1Efggrk= X-Gm-Gg: ASbGncvs8dKWnN0bJPZJOG7g09I+4oqVwKUGb0/PRumqp7wVuMAuhqDSZ22AjL3j3Sr G+TXXrdCETyUQRBncSWQ9Zpty6FYChlcce1tRLcGrkIkSrpZlQbXNN8mzBjiMSj9auT0UPEOpLK acwA9b0HGSSEAkTkSxGJVVh/7C6Lp0bnmi43TMhvovwiC0UXgv33/7DLWPemllfZ9mHYdDgnUWI GuSC6vM0NkBRM6GiIeJm4ML4Mqk+R5M7kszi6qcI9cwmadM3/0NHSdwrXXcuAW40HLoYpd40kDN nCJjrauD69yFc5kDU+KIQfi9KWO2jcr/W9F3BXrbuFBM71swilI/mWFpd791oZ0wpbTvEkzNv4n GxDLXbxpsD7j4chdViSt5o5O8+aArciMe/dyu7XH2uWYzJ4zo7xIIvT+F129dPLA9qkJGik9dmG sUfDMR4ymtHRan2qjQ+9KfVp2tXc3ukw== X-Google-Smtp-Source: AGHT+IFVA35Nb2ITQ5xm+F2H5nsoLi18hCULy2IxfZciFpoZhuuHzO03Eo2afLQfaNulmRaf+6lTnw== X-Received: by 2002:a17:907:72d5:b0:afe:a6d3:b4a2 with SMTP id a640c23a62f3a-b01d8a39b3fmr584547966b.11.1756684423063; Sun, 31 Aug 2025 16:53:43 -0700 (PDT) Received: from [192.168.0.19] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b0432937e0esm59177966b.3.2025.08.31.16.53.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Aug 2025 16:53:42 -0700 (PDT) Message-ID: Date: Mon, 1 Sep 2025 00:53:39 +0100 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: platform: Add Lenovo Thinkpad T14s EC To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bjorn Andersson , Konrad Dybcio , Mark Pearson Cc: "Derek J. Clark" , Henrique de Moraes Holschuh , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20250831-thinkpad-t14s-ec-v1-0-6e06a07afe0f@collabora.com> <20250831-thinkpad-t14s-ec-v1-1-6e06a07afe0f@collabora.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250831-thinkpad-t14s-ec-v1-1-6e06a07afe0f@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/08/2025 22:28, Sebastian Reichel wrote: > Add binding for the EC found in the Thinkpad T14s Gen6 Snapdragon, > which is based on the Qualcomm X1 Elite. Some of the system LEDs > and extra keys are only accessible via the EC. > > Signed-off-by: Sebastian Reichel > --- > .../bindings/platform/lenovo,thinkpad-t14s-ec.yaml | 49 ++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/Documentation/devicetree/bindings/platform/lenovo,thinkpad-t14s-ec.yaml b/Documentation/devicetree/bindings/platform/lenovo,thinkpad-t14s-ec.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..bab20df2d9ede9a3cb0359944b26b3d18ff7d9b8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/platform/lenovo,thinkpad-t14s-ec.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/platform/lenovo,thinkpad-t14s-ec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lenovo Thinkpad T14s Embedded Controller. > + > +maintainers: > + - Sebastian Reichel > + > +description: > + The Qualcomm Snapdragon-based Lenovo Thinkpad T14s has an Embedded Controller > + (EC) which handles things such as keyboard backlight, LEDs or non-standard keys. > + This binding describes the interface, on an I2C bus, to this EC. > + > +properties: > + compatible: > + const: lenovo,thinkpad-t14s-ec > + > + reg: > + const: 0x28 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - |+ > + #include > + i2c1 { > + clock-frequency = <400000>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + embedded-controller@28 { > + compatible = "lenovo,thinkpad-t14s-ec"; > + reg = <0x28>; > + interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +... > Reviewed-by: Bryan O'Donoghue