Re: [PATCH 07/10] platform/x86/amd/hsmp: Use name space while exporting module symbols

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Thu, 27 Jun 2024, Suma Hegde wrote:

> hsmp_send_message() is exported with AMD_HSMP name space.
> The other modules who would like to use this symbol,
> need to import AMD_HSMP namespace using MODULE_IMPORT_NS()
> to get away with warning.
> 
> Signed-off-by: Suma Hegde <suma.hegde@amd.com>
> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
> ---
>  drivers/platform/x86/amd/hsmp/hsmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/amd/hsmp/hsmp.c b/drivers/platform/x86/amd/hsmp/hsmp.c
> index 8cad5e813947..4bf598021f4a 100644
> --- a/drivers/platform/x86/amd/hsmp/hsmp.c
> +++ b/drivers/platform/x86/amd/hsmp/hsmp.c
> @@ -185,7 +185,7 @@ int hsmp_send_message(struct hsmp_message *msg)
>  
>  	return ret;
>  }
> -EXPORT_SYMBOL_GPL(hsmp_send_message);
> +EXPORT_SYMBOL_NS_GPL(hsmp_send_message, AMD_HSMP);
>  
>  int hsmp_test(u16 sock_ind, u32 value)
>  {
> 

Hmm, there seem to be no in-kernel users of this as you didn't need to do 
any user side import adaptation...

-- 
 i.