Re: [PATCH v6 3/8] platform/x86/amd/pmf: Add feature discovery support to util interface

[Shyam Sundar S K <Shyam-sundar.S-k@amd.com>]

On 6/8/2026 18:43, Ilpo Järvinen wrote:
> On Mon, 8 Jun 2026, Hans de Goede wrote:
>> On 27-May-26 4:02 PM, Shyam Sundar S K wrote:
>>> Add feature discovery capability to the util layer interface, allowing
>>> userspace tools to query which PMF features are supported and enabled
>>> on the current platform.
>>>
>>> The following features can now be queried through the
>>> /dev/amdpmf_interface ioctl:
>>> *  Auto Mode: Automatic power profile switching based on system activity
>>> *  Static Power Slider: User-selectable power profiles
>>> *  Policy Builder (Smart PC): Action based policy management
>>> *  Dynamic Power Slider AC: Adaptive power profiles when on AC power
>>> *  Dynamic Power Slider DC: Adaptive power profiles when on battery
>>>
>>> Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com>
>>> Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
>>> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
>>> ---
>>>  include/uapi/linux/amd-pmf.h | 11 +++++++++++
>>>  1 file changed, 11 insertions(+)
>>>
>>> diff --git a/include/uapi/linux/amd-pmf.h b/include/uapi/linux/amd-pmf.h
>>> index d29a4abe1145..9de054cfeee7 100644
>>> --- a/include/uapi/linux/amd-pmf.h
>>> +++ b/include/uapi/linux/amd-pmf.h
>>> @@ -14,6 +14,7 @@
>>>  #ifndef _UAPI_LINUX_AMD_PMF_H
>>>  #define _UAPI_LINUX_AMD_PMF_H
>>>  
>>> +#include <linux/bits.h>
>>>  #include <linux/ioctl.h>
>>>  #include <linux/types.h>
>>>  
>>> @@ -34,9 +35,19 @@
>>>  
>>>  #define AMD_PMF_BIOS_PARAMS_MAX		10
>>>  
>>> +/* AMD PMF feature flags - bitmask indicating supported features */
>>> +#define AMD_PMF_FEAT_AUTO_MODE			BIT(0)
>>> +#define AMD_PMF_FEAT_STATIC_POWER_SLIDER	BIT(1)
>>> +#define AMD_PMF_FEAT_POLICY_BUILDER		BIT(2)
>>> +#define AMD_PMF_FEAT_DYNAMIC_POWER_SLIDER_AC	BIT(3)
>>> +#define AMD_PMF_FEAT_DYNAMIC_POWER_SLIDER_DC	BIT(4)
>>> +
>>>  struct amd_pmf_info {
>>>  	__u64 size;
>>>  
>>> +	/* Feature info */
>>> +	__u32 features_supported;
>>> +
>>>  	/* Power and state info */
>>>  	__u32 platform_type;
>>>  	__u32 power_source;
>>
>> You are now changing the userspace ABI between patch 1 and
>> this patch. Please just squash this patch into patch 1.

Ack to the remarks in 1/8 and this one.

> 
> I asked to only create the interface towards the end of the series so 
> there is no real problem from the ordering.
> 

Ilpo, Squashed it in patch1, please check if this sounds good to you.

Thanks,
Shyam