From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit Date: Fri, 17 Aug 2018 21:30:12 +1000 Message-ID: References: <7ccdc39d7e255547e851497ef9f449715b45f8bd.camel@kernel.crashing.org> <6a2826055a33cbca45c3e8e03b1b0935b9f1d1af.camel@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: "Lee, Chun-Yi" , Darren Hart , Platform Driver , "linux-kernel@vger.kernel.org" List-Id: platform-driver-x86.vger.kernel.org On Fri, 2018-08-17 at 14:27 +0300, Andy Shevchenko wrote: > On Fri, Aug 17, 2018 at 2:22 PM, Benjamin Herrenschmidt > wrote: > > On Fri, 2018-08-17 at 14:09 +0300, Andy Shevchenko wrote: > > > On Fri, Aug 17, 2018 at 2:07 PM, Andy Shevchenko > > > wrote: > > > > On Thu, Aug 16, 2018 at 2:27 AM, Benjamin Herrenschmidt > > > > wrote: > > > > > This driver prints that "Unsupported machine..." message on every boot on > > > > > ThinkPad X1 Carbon laptops (and I assume a number of other systems), which > > > > > causes graphical boots to "glitch" a bit and is rather annoying ... > > > > > > > > > > Make it a pr_debug instead. > > > > > > > > Thanks for the patch. Unfortunately it doesn't apply. > > > > Please, check your mail clients and tools for formatting patch (it > > > > produced at the end spaces instead of tabs) > > > > > > No need to resend _this_ time. I have pushed to my review and testing queue. > > > > Thanks, odd. Not sure what's going on with the latest evolution, it's > > the second time it's done this. I'll try to investigate. Small patch > > like that I tend to just copy/paste in an email in "preformat" style > > ;-) > > Evolution is totally broken for years already (yes, I'm still using it > due to Outlook Web Services support, but it's utter PITA). > I could just easily come up with couple of dozens of bugs that are > present there for more than 3 years. I had reasonably good luck getting bugs fixed by reporting them via Fedora actually. But yeah, something with the composer tends to break regularly. Cheers, Ben. > > > > Cheers, > > Ben. > > > > > > > > > > > > > Signed-off-by: Benjamin Herrenschmidt > > > > > --- > > > > > > > > > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c > > > > > index 8952173dd380..7f7192e8fdab 100644 > > > > > --- a/drivers/platform/x86/acer-wmi.c > > > > > +++ b/drivers/platform/x86/acer-wmi.c > > > > > @@ -2216,7 +2216,7 @@ static int __init acer_wmi_init(void) > > > > > if (wmi_has_guid(AMW0_GUID1) && > > > > > !dmi_check_system(amw0_whitelist) && > > > > > quirks == &quirk_unknown) { > > > > > - pr_err("Unsupported machine has AMW0_GUID1, unable to load\n"); > > > > > + pr_debug("Unsupported machine has AMW0_GUID1, unable to load\n"); > > > > > return -ENODEV; > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > With Best Regards, > > > > Andy Shevchenko > > > > > > > > > > > >