From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13433C4332F for ; Mon, 7 Nov 2022 11:25:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbiKGLZy (ORCPT ); Mon, 7 Nov 2022 06:25:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbiKGLZx (ORCPT ); Mon, 7 Nov 2022 06:25:53 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3C3818B05 for ; Mon, 7 Nov 2022 03:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667820300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hutdt2b2zeKy7OYI4K1JmV0ps00YTwE6Wdz0pL2yeQU=; b=KM5UtgGQWJHsgrQjD93L6CV2wg5DaBF78eDfStk9xmdhAxg+1EPCeUIwdqjKQB8NSh733T 30rOWG/IIqGX13HORpbstojb3vpwtFUgRMh5tDokzmAddpPY1BUUypvJYQlYVkB5Aa2XPP DzLSwZycGJEu2v7PDiPprau/2hx6/Ns= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-2-vdjnewdEM_KoCyzg-1CF-A-1; Mon, 07 Nov 2022 06:23:47 -0500 X-MC-Unique: vdjnewdEM_KoCyzg-1CF-A-1 Received: by mail-ed1-f69.google.com with SMTP id f17-20020a056402355100b00466481256f6so2394064edd.19 for ; Mon, 07 Nov 2022 03:23:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hutdt2b2zeKy7OYI4K1JmV0ps00YTwE6Wdz0pL2yeQU=; b=RL2wzIwbwAhJ9xfUgCVus1ZxvgTppdmlMSsLetXZpOaupJEByObjkSM7OJkGjjH9+z X0o04rTogbhjaSXqN+Xx5X24Yj1c5WfRUqwtWHWxEuW/1INEYWkna2tVhG3/MPSrLVUI xYaNab4gUMXEZ73EE7VK608nTKNlqzq8gNIQIQqrYmb4DtZJWdfgpRcA9nFfobF8F2Kh aen5PvUY1SsagXJqdq2i0cHAUfGbtcasN5vua51l32hBm/h2tIsg7baOoZVFaxM/mVNk 72W5SonGmfAgFbHNPwfRIW4uX875bpc7CKZMC52JMQPcQTBewllFGjIubZ53Smk9XGNy uUsQ== X-Gm-Message-State: ACrzQf0XOjs7HFrD7yu0KbOTh2Lx6fSEhowUpnQamRhEklNrensgDQWQ s3Momyp5k0qXDfwLM2IX82tOwfDu7RmMCknXlEdtseF3ic55Tn92QXzYwuQvHN4vFkl8B30wpwi Yba21tmlNC3o7hlCYUbyLvlh2k2XMPEdedg== X-Received: by 2002:a50:cc07:0:b0:453:4427:a918 with SMTP id m7-20020a50cc07000000b004534427a918mr50041933edi.121.1667820226208; Mon, 07 Nov 2022 03:23:46 -0800 (PST) X-Google-Smtp-Source: AMsMyM4fYJi1/SwA6LMBqIMykwtjeej5rPZlI3rCD0qmPp5eOIKxD3rIsrNsqe5MZuK5MVHNiJ9ycg== X-Received: by 2002:a50:cc07:0:b0:453:4427:a918 with SMTP id m7-20020a50cc07000000b004534427a918mr50041920edi.121.1667820226040; Mon, 07 Nov 2022 03:23:46 -0800 (PST) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id qw8-20020a1709066a0800b0073d7ab84375sm3340770ejc.92.2022.11.07.03.23.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 03:23:45 -0800 (PST) Message-ID: Date: Mon, 7 Nov 2022 12:23:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v1 1/1] platform/x86: p2sb: Don't fail if unknown CPU is found Content-Language: en-US To: Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Gross , Jarkko Nikula References: <20221104154916.35231-1-andriy.shevchenko@linux.intel.com> From: Hans de Goede In-Reply-To: <20221104154916.35231-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 11/4/22 16:49, Andy Shevchenko wrote: > We have accessing P2SB from a very few places for quite known hardware. > > When a new SoC appears in intel-family.h it's not obvious that it needs > to be added to p2sb.c as well. Instead, provide default BDF and refactor > p2sb_get_devfn() to always succeed. If in the future we would need to > exclude something, we may add a list of unsupported IDs. > > Without this change the iTCO on Intel Commet Lake SoCs became unavailable: > > i801_smbus 0000:00:1f.4: failed to create iTCO device > > Fixes: 5c7b9167ddf8 ("i2c: i801: convert to use common P2SB accessor") > Reported-by: Jarkko Nikula > Signed-off-by: Andy Shevchenko Thanks. I've merged this now, with the Commet Lake spelling error fixed and with Jarko's Tested-by added. I'll include this in my upcoming fixes pull-req to Linus. Regards, Hans > --- > drivers/platform/x86/p2sb.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/platform/x86/p2sb.c b/drivers/platform/x86/p2sb.c > index 384d0962ae93..1cf2471d54dd 100644 > --- a/drivers/platform/x86/p2sb.c > +++ b/drivers/platform/x86/p2sb.c > @@ -19,26 +19,23 @@ > #define P2SBC 0xe0 > #define P2SBC_HIDE BIT(8) > > +#define P2SB_DEVFN_DEFAULT PCI_DEVFN(31, 1) > + > static const struct x86_cpu_id p2sb_cpu_ids[] = { > X86_MATCH_INTEL_FAM6_MODEL(ATOM_GOLDMONT, PCI_DEVFN(13, 0)), > - X86_MATCH_INTEL_FAM6_MODEL(ATOM_GOLDMONT_D, PCI_DEVFN(31, 1)), > - X86_MATCH_INTEL_FAM6_MODEL(ATOM_SILVERMONT_D, PCI_DEVFN(31, 1)), > - X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE, PCI_DEVFN(31, 1)), > - X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE_L, PCI_DEVFN(31, 1)), > - X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE, PCI_DEVFN(31, 1)), > - X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_L, PCI_DEVFN(31, 1)), > {} > }; > > static int p2sb_get_devfn(unsigned int *devfn) > { > + unsigned int fn = P2SB_DEVFN_DEFAULT; > const struct x86_cpu_id *id; > > id = x86_match_cpu(p2sb_cpu_ids); > - if (!id) > - return -ENODEV; > + if (id) > + fn = (unsigned int)id->driver_data; > > - *devfn = (unsigned int)id->driver_data; > + *devfn = fn; > return 0; > } >