From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andy@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
platform-driver-x86@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] gpio: tps68470: Allow building as module
Date: Tue, 11 Jan 2022 12:46:16 +0100 [thread overview]
Message-ID: <dd4387d7-76e7-2831-18ce-c57bfdb3f9a4@redhat.com> (raw)
In-Reply-To: <Yd1qgTKIFa7pTEwg@smile.fi.intel.com>
Hi,
On 1/11/22 12:31, Andy Shevchenko wrote:
> On Tue, Jan 11, 2022 at 11:56:32AM +0100, Hans de Goede wrote:
>> The gpio-tps68470 driver binds to a tps68470-gpio platform-device which
>> itself gets instantiated by a special MFD driver from
>> drivers/platform/x86/intel/int3472/tps68470.c
>>
>> This MFD driver itself can be built as a module, so it makes no sense to
>> force the gpio-tps68470 driver to always be built-in.
>>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
>> Changes in v2:
>> - Fix some spelling errors in the commit msg
>> - Remove blank line between tps68470_gpio_driver decleration and
>> module_platform_driver(tps68470_gpio_driver)
>
> It used to be 2 patches in the series, are you going to send another one
> separately?
Ah right, I forgot this was a series. The other one had no review comments,
so v1 is still valid, you can find it here:
https://lore.kernel.org/linux-gpio/20211225120026.95268-2-hdegoede@redhat.com/
Regards,
Hans
next prev parent reply other threads:[~2022-01-11 11:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 10:56 [PATCH v2] gpio: tps68470: Allow building as module Hans de Goede
2022-01-11 11:31 ` Andy Shevchenko
2022-01-11 11:46 ` Hans de Goede [this message]
2022-01-11 12:02 ` Andy Shevchenko
2022-01-11 12:03 ` Andy Shevchenko
2022-01-11 12:13 ` Hans de Goede
2022-01-11 12:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd4387d7-76e7-2831-18ce-c57bfdb3f9a4@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox