From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost converter as regulator Date: Tue, 8 Aug 2017 11:00:33 +0200 Message-ID: References: <20170806123555.5124-1-hdegoede@redhat.com> <20170806123555.5124-14-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Liam Breck Cc: devel@driverdev.osuosl.org, Heikki Krogerus , linux-kernel , Wolfram Sang , Tony Lindgren , Greg Kroah-Hartman , linux-pm@vger.kernel.org, Sebastian Reichel , platform-driver-x86@vger.kernel.org, Andy Shevchenko , Darren Hart , Guenter Roeck , linux-i2c@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org Hi, On 08-08-17 10:39, Liam Breck wrote: > Hi Hans, > > On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede wrote: >> Register the 5V boost converter as a regulator named >> "regulator-bq24190-usb-vbus". Note the name includes "bq24190" because >> the bq24190 family is also used on ACPI devices where there are no >> device-tree phandles, so regulator_get will fallback to the name and thus >> it must be unique on the system. > > What we're enabling here is 5V boost for otg host mode, not vbus > generally, so maybe the name should indicate that... > > regulator-bq24190-usb-5volt > regulator-bq24190-usb-host > regulator-bq24190-usb-otg-5v I picked vbus because that gets used a lot already in similar cases, but I agree that we should probably come up with a better name. I like "regulator-bq24190-usb-otg-5v", shall I use that for v2? Regards, Hans