From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79B7414B978 for ; Mon, 12 Aug 2024 20:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723494617; cv=none; b=PFTrfuo/coekUGfXrNczwpgo6j2Rv2BeRgJOzfiOUEJZIZZ3zM+Z7wmnXJzENQdvjc/5GAdQabC27snFVKL/sJ60hhHVe/z841R9mMTOleGQsYul4F6gWz/2iMyOReHCC14AtIh1+GWW3fQqt3gAY+J+tS4I8x3o9yfQSnnFJDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723494617; c=relaxed/simple; bh=b+fOw0HfrYbHHJSFLtHz2DQ5lSVg+JzT2Fi9wPOX0zM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sWsBFphXxb5+znlB8RAu7T0JD13CxAxPMm9zHHCMar81mxVCbcBAVSeMIwWurZ5S1jR3VxSfLvIdP/VpUP40Mar3y+RMDejcRCtnGGODwBuZmfbWj1dyJAyoMfnB0ICUQiJBNi7ywAVQzGDXFUXd8l26DcTi5SZbKE58cB+AHbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AMjlMHd7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AMjlMHd7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723494615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MDvJJylq/moYq+QuSMRAZKQLpyZRrzL3yU2+Tfj/j30=; b=AMjlMHd7jsvXApHmnsWlJcUubaxcCh/VozU2UWNuugkrz/ZQ+wX1yYFCmSr3uI1Lz4hW/m g+MQFBt0+jQxIds92ii8xKdXYnOF8DRc5QxBCSwbkLpWEG+w2tbQMXtJgAQRvaXrQ6a4IA fmzIlJFuQrndBEaNxk/ZPmhmXZxPdhw= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-363-l5wR3xyVOM6-zOl8Y0iREQ-1; Mon, 12 Aug 2024 16:30:12 -0400 X-MC-Unique: l5wR3xyVOM6-zOl8Y0iREQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a7aa56d8b14so344617566b.1 for ; Mon, 12 Aug 2024 13:30:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723494611; x=1724099411; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MDvJJylq/moYq+QuSMRAZKQLpyZRrzL3yU2+Tfj/j30=; b=ty3trgp4niJ5+9AP7sCVA9KU3vY7w6FPDjQiO8MUMAPjUUh9t5OeWzjPqcb6SnTHcQ 7habAslWo1AWYG3drPA9d7RAAFcwOgWLx3POHrQ1yQTllmHmR0FK2XeOPEoOSDXO+LGr ZO6jza23VpS2uEKGvKPiRF82rT4bfnhTvz9ILLNT0Zw/ew2hcc7t1XPPWWsQts3qEoQZ H6dIzOxll3nlnuM4j/zVnxclJhhd0fcVreDjIU5W+yHJQiOxhd6f0IEQ90zhcXp5his4 iSnbZ9Ys0mbTiIFtIfAeWfvt2jhpUbKgoU1NamRu01rs06SIFyw2frmzn0SEcEnq/on8 uhIQ== X-Forwarded-Encrypted: i=1; AJvYcCVa6CRw7Z2/fOkH5x7J2My87uUS7CBQUQn37js/gOHHi3tyrU8ZWJ1FS1cOHet/qnROyVAokMrp3pnpDeNWk3DDggt/@vger.kernel.org X-Gm-Message-State: AOJu0YyNE4zFYzUjtQYyZBHcsLAxdMyrXQMXFiK88X36/PEMPARLR9dp tD7CrYbNmS8odbd38TYfTogz7cCNkQta79yUHxO/2wBr7StO7ER87kVMOLbFy3BGKCp9eVZygp6 lT3BqfjkgqGNmYtcQd8UZDwEYTfy7ZJQKYrN1StArY1l08A/TFbjXrkrCwMb1DFiC1dHUJuA= X-Received: by 2002:a17:907:9495:b0:a72:aeff:dfed with SMTP id a640c23a62f3a-a80ed2cf7bemr97946966b.53.1723494610796; Mon, 12 Aug 2024 13:30:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6K9VOrKZwhNIzn/L3nC60slMnzZve3t9q0ouYa/y67L5SW0kEllswsZyJfD6tkYNhLJkZWA== X-Received: by 2002:a17:907:9495:b0:a72:aeff:dfed with SMTP id a640c23a62f3a-a80ed2cf7bemr97945666b.53.1723494610310; Mon, 12 Aug 2024 13:30:10 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f411bdc0sm7845466b.118.2024.08.12.13.30.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 13:30:09 -0700 (PDT) Message-ID: Date: Mon, 12 Aug 2024 22:30:09 +0200 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 6/6] platform/x86: dell-smo8800: Add support for probing for the accelerometer i2c address To: Andy Shevchenko Cc: =?UTF-8?Q?Pali_Roh=C3=A1r?= , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko , Paul Menzel , Wolfram Sang , eric.piel@tremplin-utc.net, Marius Hoch , Dell.Client.Kernel@dell.com, Kai Heng Feng , platform-driver-x86@vger.kernel.org, Jean Delvare , Andi Shyti , linux-i2c@vger.kernel.org References: <20240805133708.160737-1-hdegoede@redhat.com> <20240805133708.160737-7-hdegoede@redhat.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, On 8/5/24 10:51 PM, Andy Shevchenko wrote: > On Mon, Aug 5, 2024 at 3:39 PM Hans de Goede wrote: >> >> Unfortunately the SMOxxxx ACPI device does not contain the i2c-address >> of the accelerometer. So a DMI product-name to address mapping table >> is used. >> >> At support to have the kernel probe for the i2c-address for modesl > > models > >> which are not on the list. >> >> The new probing code sits behind a new probe_i2c_addr module parameter, >> which is disabled by default because probing might be dangerous. > > ... > >> +static int detect_lis3lv02d(struct i2c_adapter *adap, unsigned short addr) >> +{ >> + union i2c_smbus_data smbus_data; >> + int err; >> + >> + pr_info("Probing for lis3lv02d on address 0x%02x\n", addr); > > Using dev_info() against an adapter device might be more useful, no? Ack, good idea, added for v8. Regards, Hans