From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFA641E2027 for ; Wed, 4 Sep 2024 18:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725475330; cv=none; b=CNPll0UtRnulkW7J/VyPlPhZOcRO8/n9bsR0aexGdazrvM1eEaizUwtzsStc3VeUe0ahl4R+kE6JAikjfZvOaRarRhxR6oB0r+1v9l7gTz6jnu25AAQ3tqN+B8PyYEmUO46ygrmUaCQKN9ZC7mQvRiris3OYry12oFC5aoY8EMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725475330; c=relaxed/simple; bh=KU0DM89FP7NNLSMII7Kar7HQTWZDTibSYwQxMpWSXS4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lx8m38TPsRN8EXOfE4p3Yq8c+igKVe9klhAhltA1yAk9ymz6A7UybiMBItKYlzXNU8fQAs8HF1TysGryfKK+nlEgSth+9jGQjp+4R0aifKVRpnxdzCh6popu2GqG6m8lzKa0fUwVbfus0WKoU3bwBg08A8631gZXUnd9NHPrGAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IZ6AZpoP; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IZ6AZpoP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725475326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wiStKQr5MQ3eQ9f3Frd483InuNNxa84CGz2fxljewuc=; b=IZ6AZpoPOMVp76aHxJtyG7Cd8tFJ31ewDPwtQhc+8r9mwcGgOyA8AygMfXTwYFhzME0gf6 t2nAXYP43MLAu82HQG8uaryGkhjsiyKabY4T1xzaUMsRHDF2KsewkrYjcK3nOHmPPlc0Er j1gmG9rv9oSqtnBy6N3rkLWxhZFqQyE= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-Z8Cu91yvMX6HoNGV7M4uAw-1; Wed, 04 Sep 2024 14:42:05 -0400 X-MC-Unique: Z8Cu91yvMX6HoNGV7M4uAw-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a868403dbdeso539294066b.1 for ; Wed, 04 Sep 2024 11:42:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725475324; x=1726080124; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wiStKQr5MQ3eQ9f3Frd483InuNNxa84CGz2fxljewuc=; b=AhokYuZjcxK6huiPQ+dSHqmVXqRfmBPZDhMBC2d3iIFBM1Udd3yaK8U8D69ZSePaA/ 30XCxwEd2ucppsI0BLwyM3klorluvBOBT9Oa7urBIaE7EsZv3BAVLw0Er4O6UhLII68e u2olU/If0PGhAuFX06KvTbgDGSpqZaUVzOKvX06nbtFBuG33lCp6yb3E7KFWoIsBUtWt Nv28M+KSyuJKdzpXUnSKDdO/wIRF1+5TEQ6XQdAwDLsun5kSgeo4X3OeC3CSdWrGFCRA vHbmKQ0CXii1Epvp99gsSBKwMgjw8jIGN3vt0wCP/DTSX2wKKA1yICLaa3csaW7bsNEM M4PQ== X-Forwarded-Encrypted: i=1; AJvYcCXsc/SR3oAqrb1hWGukrJIuTFcFqaGuUQDlNDqx7O30YEDJ5rr6Tu7l5jfUbEpWLmcDJ3LI7SMwlBRaPp52as1Qb909@vger.kernel.org X-Gm-Message-State: AOJu0YwV5nbJGBrSz9tohHpUjNlqUYMa9C2nx+FndDBZ7FvBZpxb+DQe Sdf0/NJxBe6A9bBBxkhI1hFl6AuwdQkshyJwofUOHTbOugNeHLaNtXzr4JCltU/7bbPpibQ33Nh 4t9YMPPh1ojKtAWd5QCMJq+uMmAjJYWybzni5FlZXBqXz4yD3+0TBB7DtmtusxcVLYfIrqr8= X-Received: by 2002:a17:906:8903:b0:a8a:43bd:a9e8 with SMTP id a640c23a62f3a-a8a43bdabe5mr146887766b.65.1725475324358; Wed, 04 Sep 2024 11:42:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkZm9z+b0p/5nzedvKbFagKfIqWn0+M/jiPfPzYDcTT8hChkeZMaijJmNKjc7odKysNSE4Iw== X-Received: by 2002:a17:906:8903:b0:a8a:43bd:a9e8 with SMTP id a640c23a62f3a-a8a43bdabe5mr146885366b.65.1725475323812; Wed, 04 Sep 2024 11:42:03 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a61fbae00sm23990266b.10.2024.09.04.11.42.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 11:42:03 -0700 (PDT) Message-ID: Date: Wed, 4 Sep 2024 20:42:02 +0200 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] hwmon: (hp-wmi-sensors) Check if WMI event data exists To: Guenter Roeck , Armin Wolf Cc: james@equiv.tech, jlee@suse.com, corentin.chary@gmail.com, luke@ljones.dev, matan@svgalib.org, coproscefalo@gmail.com, ilpo.jarvinen@linux.intel.com, jdelvare@suse.com, rafael@kernel.org, lenb@kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240901031055.3030-1-W_Armin@gmx.de> <20240901031055.3030-2-W_Armin@gmx.de> <6f900fd9-f850-44a3-9409-18889add2cf3@roeck-us.net> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <6f900fd9-f850-44a3-9409-18889add2cf3@roeck-us.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Guenter, On 9/4/24 8:38 PM, Guenter Roeck wrote: > On 9/4/24 10:55, Hans de Goede wrote: >> Hi All, >> >> On 9/2/24 4:28 PM, Guenter Roeck wrote: >>> On Sun, Sep 01, 2024 at 05:10:51AM +0200, Armin Wolf wrote: >>>> The BIOS can choose to return no event data in response to a >>>> WMI event, so the ACPI object passed to the WMI notify handler >>>> can be NULL. >>>> >>>> Check for such a situation and ignore the event in such a case. >>>> >>>> Fixes: 23902f98f8d4 ("hwmon: add HP WMI Sensors driver") >>>> Signed-off-by: Armin Wolf >>>> Reviewed-by: Ilpo Järvinen >>> >>> Applied. >> >> Thank you. >> >> Unfortunately patch 2/5 touches the same part of the file, >> so I cannot apply the rest of the series without first >> bringing this patch into platform-drivers-x86/for-next . >> >> Guenter, can you provide an immutable branch/tag with >> this patch on it; or drop this patch that I merge >> the entire series through platform-drivers-x86/for-next ? >> > > Can you wait a couple of days ? Since this is a bug fix, I had > planned to send a pull request either later today or; with that, > the patch would be upstream. Yes I can wait a couple of days, thank you. Regards, Hans