Re: [PATCH] platform/x86: thinkpad_acpi: Fix thinklight LED brightness returning 255

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 1/28/23 00:57, Hans de Goede wrote:
> Reading the thinklight LED brightnes while the LED is on returns
> 255 (LED_FULL) but we advertise a max_brightness of 1, so this should
> be 1 (LED_ON).
> 
> Fixes: db5e2a4ca0a7 ("platform/x86: thinkpad_acpi: Fix max_brightness of thinklight")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I've applied this to the pdx86 fixes branch now:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

and this will be included in my next fixes pull-req to Linus.

Regards,

Hans



> ---
>  drivers/platform/x86/thinkpad_acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 02860c32625e..32c10457399e 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -5563,7 +5563,7 @@ static int light_sysfs_set(struct led_classdev *led_cdev,
>  
>  static enum led_brightness light_sysfs_get(struct led_classdev *led_cdev)
>  {
> -	return (light_get_status() == 1) ? LED_FULL : LED_OFF;
> +	return (light_get_status() == 1) ? LED_ON : LED_OFF;
>  }
>  
>  static struct tpacpi_led_classdev tpacpi_led_thinklight = {