From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F11C433C1 for ; Wed, 24 Mar 2021 07:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77BA3619F6 for ; Wed, 24 Mar 2021 07:19:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232800AbhCXHTV (ORCPT ); Wed, 24 Mar 2021 03:19:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51727 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232813AbhCXHTL (ORCPT ); Wed, 24 Mar 2021 03:19:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616570349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LNxz6dk8N6Qim1jk1gv3DRN8orM2zCPzuP4pcushAnw=; b=jMPvQvEUPMzDW4rTi//xjb32aJhjzju/YQBK0RtGA0HaqCuWqiuqX4ysCShH/bIYEuhkwx S4vO7GM0Y7RkkulSzkw0oJV3lAlpQ+2xIrXKH8PtSjK3VqRcYA2OuKeD+gleJYWL9qqMc3 2k/7LtCyavvx94+pSXnjH3VSFmvIcTY= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-120-C63dObuuPuSFMPuKSInz3w-1; Wed, 24 Mar 2021 03:19:07 -0400 X-MC-Unique: C63dObuuPuSFMPuKSInz3w-1 Received: by mail-ed1-f70.google.com with SMTP id y10so552193edr.20 for ; Wed, 24 Mar 2021 00:19:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LNxz6dk8N6Qim1jk1gv3DRN8orM2zCPzuP4pcushAnw=; b=aK0EnFi2UZRPiaegNI+/fUVhchyKvSy8MWyXguAsLI96on1TUltPZ00DOSaXxAcHfS FIrkgOnSfD7cHSmXwhPG/dvgTyaaRyxnW/I/OVthr9AbBa/dGTENjtui+CLejroaMBuB 8442jBRKCIY8B5l3jqQB5MYAgSYu/AZKy+xdcpT9/CszhzrasCHfh4oxEzc/xyrwIp9W KmCPVRikoFYgcit+I+V8Wgq109OtSubqEzDXJdcSvQgpcSCBQBKrh/Wq+Fp9/22c4RgW Ltrfm5fP0Gc3fQK7I1NjthnUAjk1MCs7hj9VyeXofK0iJMaimJf7SZ3z48c4YVlaowfM b5rw== X-Gm-Message-State: AOAM533Aijgc/70jlgOmhf7X+h2k3rGqtLOigMgq3BxcDd3ZhOZhNMGK er0HwYr9Qj3p018pAspaw+mZrrr59lxpNe2WJj3IhWLEDeMCJ2O6ls2Gr8hvVAJA8iBC3YavC7S OxDuS4KEu8D/AmKDv3ercKcbmoyYaJKFs4t927TVnKTl3Re9Zvno23E8bBRicqggZ9sJUdRYnz6 2/6Nfj2dHQUA== X-Received: by 2002:a05:6402:50c8:: with SMTP id h8mr1863240edb.360.1616570345848; Wed, 24 Mar 2021 00:19:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlbfdmREJxME+JRNtvUW27K2DsKI6/XR8AbALCh74d7s9kMg/MD7c5V9abhKL5/x66UnXfjg== X-Received: by 2002:a05:6402:50c8:: with SMTP id h8mr1863215edb.360.1616570345634; Wed, 24 Mar 2021 00:19:05 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id i11sm484830ejf.76.2021.03.24.00.19.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 00:19:05 -0700 (PDT) Subject: Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init To: matti.vaittinen@fi.rohmeurope.com, Chanwoo Choi Cc: MyungJoo Ham , Andy Gross , Bjorn Andersson , Guenter Roeck , Mark Gross , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <14800e19-da8c-81ba-48ee-cc51cc1925c9@samsung.com> <1f5247a81077f6cb3c96730b1202bbd61dd1900b.camel@fi.rohmeurope.com> From: Hans de Goede Message-ID: Date: Wed, 24 Mar 2021 08:19:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <1f5247a81077f6cb3c96730b1202bbd61dd1900b.camel@fi.rohmeurope.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 3/24/21 6:02 AM, Matti Vaittinen wrote: > Hello Chanwoo, Greg, > > Thanks for the review. > > On Wed, 2021-03-24 at 11:09 +0900, Chanwoo Choi wrote: >> Hi, >> >> Need to fix the work as following: >> s/extconn/extcon >> >> And I'd like you to use the more correct patch title like the >> following example: >> "extcon: Use resource-managed function for delayed work" > > I think Greg merged this already. How should we handle this? > >> @@ -112,7 +113,9 @@ static int gpio_extcon_probe(struct >>> platform_device *pdev) >>> if (ret < 0) >>> return ret; >>> >>> - INIT_DELAYED_WORK(&data->work, gpio_extcon_work); >>> + ret = devm_delayed_work_autocancel(dev, &data->work, >>> gpio_extcon_work); >>> + if (ret) >>> + return ret; >> >> Need to add the error log as following: >> if (ret) { >> dev_err(dev, "Failed to initialize delayed_work"); >> return ret; >> } > > I could send incremental patch to Greg for this but it does not change > the commit message. We cannot do anything about the commit message anymore, but the ordering issue which you introduced really needs to be fixed. Please send an incremental patch fixing the wrong order and the double init of the workqueue. Regards, Hans