Re: [PATCH 1/2] platform/x86/intel/uncore-freq: Replace sprintf() with snprintf()

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Tue, 30 Dec 2025, Kaushlendra Kumar wrote:

> Replace unbounded sprintf() calls with snprintf() to prevent potential
> buffer overflows when formatting device names. While the current format
> strings cannot overflow the buffer, using snprintf() follows kernel
> best practices for string formatting.
> 
> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
> ---
>  .../x86/intel/uncore-frequency/uncore-frequency-common.c     | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c
> index 65897fae17df..c129dd450360 100644
> --- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c
> +++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c
> @@ -269,9 +269,10 @@ int uncore_freq_add_entry(struct uncore_data *data, int cpu)
>  			goto uncore_unlock;
>  
>  		data->instance_id = ret;
> -		sprintf(data->name, "uncore%02d", ret);
> +		snprintf(data->name, sizeof(data->name), "uncore%02d", ret);
>  	} else {
> -		sprintf(data->name, "package_%02d_die_%02d", data->package_id, data->die_id);
> +		snprintf(data->name, sizeof(data->name), "package_%02d_die_%02d",
> +			 data->package_id, data->die_id);
>  	}
>  
>  	uncore_read(data, &data->initial_min_freq_khz, UNCORE_INDEX_MIN_FREQ);

Hi,

Thanks for the patch. Please use scnprintf() instead. You don't use the 
return value so the distinction doesn't make a difference but it would be 
useful to eventually only have one of them remaining, which should be 
scnprintf() that gives a more sane return value than snprintf().

-- 
 i.