Re: [PATCH v2 2/3] platform/x86: x86-android-tablets: Add support for getting i2c_adapter by PCI parent devname()

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

On Tue, 5 Nov 2024, Hans de Goede wrote:

> Hi,
> 
> On 5-Nov-24 9:22 AM, Andy Shevchenko wrote:
> > On Mon, Nov 4, 2024 at 10:09 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >>
> >> On the Vexia EDU ATLA 10 tablet, which ships with Android + a custom Linux
> >> (guadalinex) using the custom Android kernel the I2C controllers are not
> >> enumerated as ACPI devices as they typically are.
> >>
> >> Instead they are enumerated as PCI devices which do not have ACPI firmware
> >> nodes associated with them, so getting the i2c_adapter by the ACPI path of
> >> its firmware node does not work.
> >>
> >> Add support for getting the i2c_adapter by the devname() of its PCI parent
> >> instead.
> > 
> > Reviewed-by: Andy Shevchenko <andy@kernel.org>
> > 
> > ...
> > 
> >>         struct i2c_board_info board_info = client_info->board_info;
> >> -       struct i2c_adapter *adap;
> >> +       struct i2c_adapter *adap = NULL;
> > 
> > Unneeded change.
> 
> Ack I noticed this myself and I thought I had dropped this change,
> but apparently I did not.
> 
> Ilpo can you fix this up while merging or do you want a v3 series?

Thanks both.

I removed this change while applying. I also made minor adjustments to the 
braces in the patch 3 for stylish consistency.

-- 
 i.