From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Emre Cecanpunar <emreleno@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
Hans de Goede <hansg@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
krishna.chomal108@gmail.com
Subject: Re: [PATCH v2 0/5] platform/x86: hp-wmi: Victus S fan control fixes
Date: Tue, 24 Mar 2026 17:46:46 +0200 (EET) [thread overview]
Message-ID: <f3153599-36df-e4b1-4457-201050a8e7f4@linux.intel.com> (raw)
In-Reply-To: <20260322190624.35162-1-emreleno@gmail.com>
On Sun, 22 Mar 2026, Emre Cecanpunar wrote:
> This series fixes several bugs in the Victus S fan control code.
>
> Changes in v2:
> - Patch 4: Drop the if (gpu_delta < 0) guard and pr_warn. A negative
> delta is valid firmware behavior on boards where CPU_RPM > GPU_RPM.
> Store gpu_delta as 'int' in struct hp_wmi_hwmon_priv so that the
> existing signed arithmetic and clamp_val() in hp_wmi_fan_speed_set()
> handle the negative case correctly without saturating at U8_MAX.
>
> Emre Cecanpunar (5):
> platform/x86: hp-wmi: fix ignored return values in fan settings
> platform/x86: hp-wmi: avoid cancel_delayed_work_sync from work handler
> platform/x86: hp-wmi: use mod_delayed_work to reset keep-alive timer
> platform/x86: hp-wmi: fix u8 underflow in gpu_delta calculation
> platform/x86: hp-wmi: add locking for concurrent hwmon access
You should all so add Fixes tags to these changes, they're currently
missing from all of them.
--
i.
prev parent reply other threads:[~2026-03-24 15:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 19:06 [PATCH v2 0/5] platform/x86: hp-wmi: Victus S fan control fixes Emre Cecanpunar
2026-03-22 19:06 ` [PATCH v2 1/5] platform/x86: hp-wmi: fix ignored return values in fan settings Emre Cecanpunar
2026-03-22 19:06 ` [PATCH v2 2/5] platform/x86: hp-wmi: avoid cancel_delayed_work_sync from work handler Emre Cecanpunar
2026-03-22 19:06 ` [PATCH v2 3/5] platform/x86: hp-wmi: use mod_delayed_work to reset keep-alive timer Emre Cecanpunar
2026-03-23 9:51 ` Ilpo Järvinen
2026-03-22 19:06 ` [PATCH v2 4/5] platform/x86: hp-wmi: fix u8 underflow in gpu_delta calculation Emre Cecanpunar
2026-03-23 9:42 ` Ilpo Järvinen
2026-03-22 19:06 ` [PATCH v2 5/5] platform/x86: hp-wmi: add locking for concurrent hwmon access Emre Cecanpunar
2026-03-24 15:46 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3153599-36df-e4b1-4457-201050a8e7f4@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=emreleno@gmail.com \
--cc=hansg@kernel.org \
--cc=krishna.chomal108@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox