Re: [PATCH 03/11] platform/x86/amd/hsmp: Null-check drvdata in hsmp_is_sock_attr_visible()

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Thu, 8 Oct 2026, Suma Hegde wrote:

> From: Suma Hegde <Suma.Hegde@amd.com>
> 
> dev_get_drvdata() can return NULL if probe failed before setting the
> socket pointer. Check for that before reading sock->proto_ver so the
> sysfs visibility callback cannot NULL-dereference.
> 
> Co-developed-by: Muthusamy Ramalingam <Muthusamy.Ramalingam@amd.com>
> Signed-off-by: Muthusamy Ramalingam <Muthusamy.Ramalingam@amd.com>
> Signed-off-by: Suma Hegde <Suma.Hegde@amd.com>
> ---
>  drivers/platform/x86/amd/hsmp/acpi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/hsmp/acpi.c b/drivers/platform/x86/amd/hsmp/acpi.c
> index 088c44ea1782e..0e412c23c69c8 100644
> --- a/drivers/platform/x86/amd/hsmp/acpi.c
> +++ b/drivers/platform/x86/amd/hsmp/acpi.c
> @@ -306,6 +306,9 @@ static umode_t hsmp_is_sock_attr_visible(struct kobject *kobj,
>  	struct device *dev = kobj_to_dev(kobj);
>  	struct hsmp_socket *sock = dev_get_drvdata(dev);
>  
> +	if (!sock)

Please put call and it's error handling next to each other, effectively 
that means moving sock assignment out of the local variable block.

> +		return 0;
> +
>  	if (!is_client_platform() && sock->proto_ver >= HSMP_PROTO_VER6)
>  		return battr->attr.mode;
>  
> 

-- 
 i.