From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2733C388F9 for ; Wed, 11 Nov 2020 10:29:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44E0720756 for ; Wed, 11 Nov 2020 10:29:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PA1cpF6W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727471AbgKKK3a (ORCPT ); Wed, 11 Nov 2020 05:29:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57377 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727215AbgKKK3a (ORCPT ); Wed, 11 Nov 2020 05:29:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605090568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6cWzQirp89MqvBGKD7feVetENzzO1kweGW8V2WA2ajE=; b=PA1cpF6WGoaXZa/nXxMGHrtxyfKu/0jxb3SvLTWdsqZmf/5DWS0Ls1BfmuFWt8Ywtyn/dh EuqerDkEGMQUmqOZPsQLMD9+AROOgCLt1yDAql6ZbiW957q5EMXOTB60C6lHr+zSrA4g7I 1j+FvW73J+67WKRuiaY+UOooah8OVaI= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-541--jQOtJ_wNBucb61_HXpbcg-1; Wed, 11 Nov 2020 05:29:26 -0500 X-MC-Unique: -jQOtJ_wNBucb61_HXpbcg-1 Received: by mail-ed1-f72.google.com with SMTP id s7so668717eds.17 for ; Wed, 11 Nov 2020 02:29:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6cWzQirp89MqvBGKD7feVetENzzO1kweGW8V2WA2ajE=; b=sT2a6JVdTQCO03dPbb9P3Vz+nd/iffs0o85mvapU7QO8jnCVlT0z2mQaKKx8GCK6oG Hq+kNjRn/ZefCbAWHExUjLw87ioG+7Ni35Tuipd9+I+Haf54ygM/p4bqgl2hi1WPPmc8 h5T7akZuqFmUsyAdbBMK3+RUl/v3KvfwkQRcs/HtHrEgHN+hyPdCeILKnL3OsR3iGtig oZGbheHOMEBmTIQzguxk5PBf7WeBlAlk8ykQ1c/eqtIYcWsw/SGa3vJUnIWBlVSpBDPZ aX5+IlhdiUpOwB9j16Z4oQy7Szz6YgF7HX760W2hK+8gNPSHIp8z1U9bKyaOCN6Ndx4R ZfIg== X-Gm-Message-State: AOAM531J/BG7hdUBRRR7dse0G6B405zTAmTID1V/kOk/0hKQbSf+6iGC BZ206xkMKEu29CFqEqtD55g2vuiebWuctBd7W8e0WFk58VardNkyMNmAxReMMtwziVhOARae2oM 5fuQZd5VLuXUSQW4Q+lUHCYXaZn6T/FMfDA== X-Received: by 2002:a17:906:f186:: with SMTP id gs6mr25435909ejb.171.1605090565303; Wed, 11 Nov 2020 02:29:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyjzxV9wekN4dOqJBwNAGPRIchMxZTQry8R7IcifjjunD6bcewyyPOkNdX01YrOA2ONYvFvxw== X-Received: by 2002:a17:906:f186:: with SMTP id gs6mr25435891ejb.171.1605090565051; Wed, 11 Nov 2020 02:29:25 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-6c10-fbf3-14c4-884c.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:6c10:fbf3:14c4:884c]) by smtp.gmail.com with ESMTPSA id hp27sm670698ejc.2.2020.11.11.02.29.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 02:29:24 -0800 (PST) Subject: Re: [External] Re: [PATCH 2/3] ACPI: platform-profile: Add platform profile support To: Mark Pearson , =?UTF-8?Q?Barnab=c3=a1s_P=c5=91cze?= Cc: "rjw@rjwysocki.net" , "mgross@linux.intel.com" , "linux-acpi@vger.kernel.org" , "mario.limonciello@dell.com" , "eliadevito@gmail.com" , "hadess@hadess.net" , "bberg@redhat.com" , "platform-driver-x86@vger.kernel.org" , "dvhart@infradead.org" References: <20201110033124.3211-1-markpearson@lenovo.com> <20201110033124.3211-3-markpearson@lenovo.com> <2gY5rkKaKLKayk0DYW0lvZ_aIAs8vSf9FOy2obdGvph_7XcpyHlkafBTpW8RHKC5nEcEz_eY-s4pJtuR2ebltW2Fu10GRssTmMxKMuS4PU8=@protonmail.com> <72b0fb0a-8007-d795-8b1a-68fa58231c23@lenovo.com> From: Hans de Goede Message-ID: Date: Wed, 11 Nov 2020 11:29:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <72b0fb0a-8007-d795-8b1a-68fa58231c23@lenovo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 11/10/20 3:32 PM, Mark Pearson wrote: > Thanks Barnabas > > On 10/11/2020 05:15, Barnabás Pőcze wrote: >> Hi >> >> I've added some questions and comments inline. >> >> >> >> 2020. november 10., kedd 4:31 keltezéssel, Mark Pearson írta: >>> +    "Low-power", >>> +    "Cool", >>> +    "Quiet", >>> +    "Balance", >>> +    "Performance", >>> +    "Unknown" >> >> "unknown" is not documented, yet it may be returned to userspace. > Ack - I'll look into if it's really needed, but it seemed sensible to have it whilst doing the implementation. AFAIK with the currently agreed upon version of the API we do not need this, please remove it. We can always add it later if necessary, but for now I would like to avoid drivers being tempted to use this. Regards, Hans