From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5C8C433F5 for ; Sun, 24 Oct 2021 08:19:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0529660ED4 for ; Sun, 24 Oct 2021 08:19:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231172AbhJXIWH (ORCPT ); Sun, 24 Oct 2021 04:22:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24953 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231285AbhJXIWF (ORCPT ); Sun, 24 Oct 2021 04:22:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635063585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iEA+bOsDY0+9yg7R/acNp9qvWIVajgO8oDCJI28qcNg=; b=NGCnPXWK5bNYKFUbrsqXfjlaRwfUnmxZMaWUCqcJUkKYPKPSORKMITtoPg+VfAvjaqkU1y 2DHAPcaFcLDVLYyA0cGo8AnjdtHnkl6Guc4N8R5uuL1TobMYPsJKkwVZgQOeVYD9zolBo1 ZiZqbizLmyQ3m4/BI7wpAjnn5AhTgPI= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-549-05i07ZqHNyeymPMuPVNcYQ-1; Sun, 24 Oct 2021 04:19:42 -0400 X-MC-Unique: 05i07ZqHNyeymPMuPVNcYQ-1 Received: by mail-ed1-f71.google.com with SMTP id d11-20020a50cd4b000000b003da63711a8aso3762064edj.20 for ; Sun, 24 Oct 2021 01:19:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iEA+bOsDY0+9yg7R/acNp9qvWIVajgO8oDCJI28qcNg=; b=ZXVYJBfwVxCLY5WA1JyDTf/BckaHH7We26sQQmJN2pR+H5sgh7w5W+6e2M1PEemepZ Q78rmPTTP4xmTFAbDJk2NNx8t1JeiBj7ycnI5rpA4mMv418zORUGL99Qrttw5ctnhak5 bXknsrotvJ4Mz9v9sYeF8ornnvrzjlxUa1afqIwRkCnYiQIyDeHhGmPbaGHz7wP3Ld5K Rr4/zXF/z5ApMi+yg8+JnzVfGeOsyaMxS3Jx4g+nIdmb4OAuee6u8nkRkcXR5kpnVLBn mU1YACfgj03MTbGZypdQ9B3b32c8V4DLI8IWDVQii8Jms7O2KEAGG/qQ9YfRh8RRCv2K MR/A== X-Gm-Message-State: AOAM532PlbXrp87fqyHI8yWqbftyYDHoKFsWIEf8ppvkipCx+0IvX4Wk dU1jNRBw8nqgxV0eX1bTse1SZg+YrrDjlGrV42r6n6zwEVMsCLpFqx5XijBNZCq6CmjoHXpBsDX dkT+L/6oZkwwb2LwC5EQun/bkJ+J29KeTEg== X-Received: by 2002:aa7:c952:: with SMTP id h18mr16344377edt.18.1635063581667; Sun, 24 Oct 2021 01:19:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5rtFBpYqxF0K9CIYe+eHutxNObi8ukisQuZC6nx0OFjTu3p+Z581qSKvqb5oWD+F57MrVvA== X-Received: by 2002:aa7:c952:: with SMTP id h18mr16344365edt.18.1635063581499; Sun, 24 Oct 2021 01:19:41 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:1054:9d19:e0f0:8214? (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id y22sm7607114edc.76.2021.10.24.01.19.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Oct 2021 01:19:41 -0700 (PDT) Message-ID: Date: Sun, 24 Oct 2021 10:19:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] platform/x86: system76_acpi: fix Kconfig dependencies Content-Language: en-US To: Arnd Bergmann , Mark Gross , Jean Delvare , Guenter Roeck , Tim Crawford , Jeremy Soller Cc: Arnd Bergmann , Andy Shevchenko , Kate Hsuan , "David E. Box" , Linus Walleij , Maximilian Luz , Alexander Duyck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org References: <20211022154901.904984-1-arnd@kernel.org> From: Hans de Goede In-Reply-To: <20211022154901.904984-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 10/22/21 17:48, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_INPUT is disabled, this driver now fails to link: > > ld.lld: error: undefined symbol: devm_input_allocate_device >>>> referenced by system76_acpi.c >>>> platform/x86/system76_acpi.o:(system76_add) in archive drivers/built-in.a > > ld.lld: error: undefined symbol: input_set_capability >>>> referenced by system76_acpi.c >>>> platform/x86/system76_acpi.o:(system76_add) in archive drivers/built-in.a > > ld.lld: error: undefined symbol: devm_hwmon_device_register_with_info >>>> referenced by system76_acpi.c >>>> platform/x86/system76_acpi.o:(system76_add) in archive drivers/built-in.a > > ld.lld: error: undefined symbol: battery_hook_unregister >>>> referenced by system76_acpi.c >>>> platform/x86/system76_acpi.o:(system76_remove) in archive drivers/built-in.a > > Add Kconfig dependencies for each of these three. > > Fixes: 0de30fc684b3 ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models") > Fixes: 95563d45b5da ("platform/x86: system76_acpi: Report temperature and fan speed") > Fixes: 76f7eba3e0a2 ("platform/x86: system76_acpi: Add battery charging thresholds") > Signed-off-by: Arnd Bergmann Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 56bcf80da60a..c422ee785c56 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -923,6 +923,9 @@ config SONYPI_COMPAT > config SYSTEM76_ACPI > tristate "System76 ACPI Driver" > depends on ACPI > + depends on ACPI_BATTERY > + depends on HWMON > + depends on INPUT > select NEW_LEDS > select LEDS_CLASS > select LEDS_TRIGGERS >