Re: [PATCH v2] [PATCH v2] platform/x86: hp-wmi: Fixed Omen MAX 16-ah0xx board name

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]

On Thu, 6 Nov 2025, Marcos Vega wrote:

> You are totally right, after more thorough testing, I realised I had made a mistake,
> board 8D41 must only go on victus_s_thermal_profile_boards.
> 
> I send the correct commit in hopes to fix this.
> This is my first time contributing to the kernel, ¡thank you for your patience!

It's no problem.

Please, send v3 with the usual changelog (see also below for one 
additional comment).

In case you need to add (additional) comments like here now is, those 
should be placed under --- line so our tools will automatically remove 
them when applying.

It's also custom to add patch version history below --- line so the 
reviewers know what was changed.

> Signed-off-by: Marcos Vega <marcosmola2@gmail.com>
> ---
>  drivers/platform/x86/hp/hp-wmi.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index 8b3533d6ba09..7a3cad80f0b5 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -92,9 +92,10 @@ static const char * const victus_thermal_profile_boards[] = {
>  	"8A25"
>  };
>  
> -/* DMI Board names of Victus 16-r1000 and Victus 16-s1000 laptops */
> +/* DMI Board names of Victus 16-r1000 and Victus 16-s1000 laptops, as well
> +   as some Omen boards using this profile */
>  static const char * const victus_s_thermal_profile_boards[] = {
> -	"8C99", "8C9C"
> +	"8C99", "8C9C", "8D41"

It would be better to base this on top of the review-ilpo-fixes branch 
which currently has many additions to this so I can easily apply this 
patch there too.

As this is a new prefix (8D), place it on own line and include the 
trailing comma (I just decided while dealing with all these recent ID 
patches, we really want to have these better organized than in the other 
disorganized array).

-- 
 i.