[PATCH] platform/x86: hp-wmi: Add Omen MAX 16-ah0xx fan support and thermal profile

[PATCH] platform/x86: hp-wmi: Add Omen MAX 16-ah0xx fan support and thermal profile

[Marcos Vega]

New HP Omen laptops follow the same WMI thermal profile as Victus 16-r1000 and 16-s1000.

Add DMI board 8D41 to omen_thermal_profile_boards as well as victus_s_thermal_profile_boards.

Tested on: HP Omen MAX 16-ah0xx (8D41)
Result:
* RPMs can be read
* echo 0 | sudo tee /sys/devices/platform/hp-wmi/hwmon/*/pwm1_enable allows the fans to run on max RPM.

Signed-off-by: Marcos Vega <marcosmola2@gmail.com>
---
 drivers/platform/x86/hp/hp-wmi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index 8b3533d6ba09..270af91dc7d0 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -68,7 +68,7 @@ static const char * const omen_thermal_profile_boards[] = {
 	"874A", "8603", "8604", "8748", "886B", "886C", "878A", "878B", "878C",
 	"88C8", "88CB", "8786", "8787", "8788", "88D1", "88D2", "88F4", "88FD",
 	"88F5", "88F6", "88F7", "88FE", "88FF", "8900", "8901", "8902", "8912",
-	"8917", "8918", "8949", "894A", "89EB", "8BAD", "8A42", "8A15"
+	"8917", "8918", "8949", "894A", "89EB", "8BAD", "8A42", "8A15", "8D41"
 };
 
 /* DMI Board names of Omen laptops that are specifically set to be thermal
@@ -92,9 +92,10 @@ static const char * const victus_thermal_profile_boards[] = {
 	"8A25"
 };
 
-/* DMI Board names of Victus 16-r1000 and Victus 16-s1000 laptops */
+/* DMI Board names of Victus 16-r1000 and Victus 16-s1000 laptops, as well
+   as some Omen boards using this profile */
 static const char * const victus_s_thermal_profile_boards[] = {
-	"8C99", "8C9C"
+	"8C99", "8C9C", "8D41"
 };
 
 enum hp_wmi_radio {
-- 
2.51.2

Re: [PATCH] platform/x86: hp-wmi: Add Omen MAX 16-ah0xx fan support and thermal profile

[Ilpo Järvinen]

On Thu, 06 Nov 2025 12:50:17 +0100, Marcos Vega wrote:

> New HP Omen laptops follow the same WMI thermal profile as Victus 16-r1000 and 16-s1000.
> 
> Add DMI board 8D41 to omen_thermal_profile_boards as well as victus_s_thermal_profile_boards.
> 
> Tested on: HP Omen MAX 16-ah0xx (8D41)
> Result:
> * RPMs can be read
> * echo 0 | sudo tee /sys/devices/platform/hp-wmi/hwmon/*/pwm1_enable allows the fans to run on max RPM.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: hp-wmi: Add Omen MAX 16-ah0xx fan support and thermal profile
      commit: 836a26660b97c62b1ed734e38a78bd20949dfa22

--
 i.

Re: [PATCH] platform/x86: hp-wmi: Add Omen MAX 16-ah0xx fan support and thermal profile

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

On Thu, 6 Nov 2025, Ilpo Järvinen wrote:

> On Thu, 06 Nov 2025 12:50:17 +0100, Marcos Vega wrote:
> 
> > New HP Omen laptops follow the same WMI thermal profile as Victus 16-r1000 and 16-s1000.
> > 
> > Add DMI board 8D41 to omen_thermal_profile_boards as well as victus_s_thermal_profile_boards.
> > 
> > Tested on: HP Omen MAX 16-ah0xx (8D41)
> > Result:
> > * RPMs can be read
> > * echo 0 | sudo tee /sys/devices/platform/hp-wmi/hwmon/*/pwm1_enable allows the fans to run on max RPM.
> > 
> > [...]
> 
> 
> Thank you for your contribution, it has been applied to my local
> review-ilpo-fixes branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> local branch there, which might take a while.
> 
> The list of commits applied:
> [1/1] platform/x86: hp-wmi: Add Omen MAX 16-ah0xx fan support and thermal profile
>       commit: 836a26660b97c62b1ed734e38a78bd20949dfa22

Actually, I take this back, I don't think you're supposed to add it to 
both lists.

-- 
 i.

[PATCH v2] [PATCH v2] platform/x86: hp-wmi: Fixed Omen MAX 16-ah0xx board name

[Marcos Vega]

You are totally right, after more thorough testing, I realised I had made a mistake,
board 8D41 must only go on victus_s_thermal_profile_boards.

I send the correct commit in hopes to fix this.
This is my first time contributing to the kernel, ¡thank you for your patience!

Signed-off-by: Marcos Vega <marcosmola2@gmail.com>
---
 drivers/platform/x86/hp/hp-wmi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index 8b3533d6ba09..7a3cad80f0b5 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -92,9 +92,10 @@ static const char * const victus_thermal_profile_boards[] = {
 	"8A25"
 };
 
-/* DMI Board names of Victus 16-r1000 and Victus 16-s1000 laptops */
+/* DMI Board names of Victus 16-r1000 and Victus 16-s1000 laptops, as well
+   as some Omen boards using this profile */
 static const char * const victus_s_thermal_profile_boards[] = {
-	"8C99", "8C9C"
+	"8C99", "8C9C", "8D41"
 };
 
 enum hp_wmi_radio {
-- 
2.51.2

Re: [PATCH v2] [PATCH v2] platform/x86: hp-wmi: Fixed Omen MAX 16-ah0xx board name

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]

On Thu, 6 Nov 2025, Marcos Vega wrote:

> You are totally right, after more thorough testing, I realised I had made a mistake,
> board 8D41 must only go on victus_s_thermal_profile_boards.
> 
> I send the correct commit in hopes to fix this.
> This is my first time contributing to the kernel, ¡thank you for your patience!

It's no problem.

Please, send v3 with the usual changelog (see also below for one 
additional comment).

In case you need to add (additional) comments like here now is, those 
should be placed under --- line so our tools will automatically remove 
them when applying.

It's also custom to add patch version history below --- line so the 
reviewers know what was changed.

> Signed-off-by: Marcos Vega <marcosmola2@gmail.com>
> ---
>  drivers/platform/x86/hp/hp-wmi.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index 8b3533d6ba09..7a3cad80f0b5 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -92,9 +92,10 @@ static const char * const victus_thermal_profile_boards[] = {
>  	"8A25"
>  };
>  
> -/* DMI Board names of Victus 16-r1000 and Victus 16-s1000 laptops */
> +/* DMI Board names of Victus 16-r1000 and Victus 16-s1000 laptops, as well
> +   as some Omen boards using this profile */
>  static const char * const victus_s_thermal_profile_boards[] = {
> -	"8C99", "8C9C"
> +	"8C99", "8C9C", "8D41"

It would be better to base this on top of the review-ilpo-fixes branch 
which currently has many additions to this so I can easily apply this 
patch there too.

As this is a new prefix (8D), place it on own line and include the 
trailing comma (I just decided while dealing with all these recent ID 
patches, we really want to have these better organized than in the other 
disorganized array).

-- 
 i.

[PATCH v3] platform/x86: hp-wmi: Moved Omen MAX 16-ah0xx board name

[Marcos Vega]

Fixed placement of board 8D41 so its categorized adequately in victus_s_thermal_profile_boards.
Rebased to review-ilpo-fixes as pointed out by maintainer.

Signed-off-by: Marcos Vega <marcosmola2@gmail.com>
---
 drivers/platform/x86/hp/hp-wmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index e10c75d91f24..47989f6a1753 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -96,6 +96,7 @@ static const char * const victus_thermal_profile_boards[] = {
 static const char * const victus_s_thermal_profile_boards[] = {
 	"8BBE", "8BD4", "8BD5",
 	"8C78", "8C99", "8C9C",
+	"8D41"
 };
 
 enum hp_wmi_radio {
-- 
2.51.2

Re: [PATCH v3] platform/x86: hp-wmi: Moved Omen MAX 16-ah0xx board name

[Ilpo Järvinen]

On Fri, 7 Nov 2025, Marcos Vega wrote:

> Fixed placement of board 8D41 so its categorized adequately in victus_s_thermal_profile_boards.
> Rebased to review-ilpo-fixes as pointed out by maintainer.

This part of the submission should contain the description of the change 
(basically, what you already had in v1).

> Signed-off-by: Marcos Vega <marcosmola2@gmail.com>
> ---

This part after the --- line should contain the things you changed between 
patch versions. E.g, like this:

v3:
- Rebased on top of review-ilpo-fixes
- Fixed placement of 8D41

>  drivers/platform/x86/hp/hp-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index e10c75d91f24..47989f6a1753 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -96,6 +96,7 @@ static const char * const victus_thermal_profile_boards[] = {
>  static const char * const victus_s_thermal_profile_boards[] = {
>  	"8BBE", "8BD4", "8BD5",
>  	"8C78", "8C99", "8C9C",
> +	"8D41"

Please add the trailing comma.

>  };


-- 
 i.

[PATCH v4] platform/x86: hp-wmi: Moved Omen MAX 16-ah0xx board name

[Marcos Vega]

Fixed placement of board 8D41 so its categorized adequately in victus_s_thermal_profile_boards.

Signed-off-by: Marcos Vega <marcosmola2@gmail.com>
---
Thank you for all the tips on proper kernel writing, I'll try to do it properly and learn for my next patch.

v4:
- Added trailing comma


 drivers/platform/x86/hp/hp-wmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index e10c75d91f24..ad9d9f97960f 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -96,6 +96,7 @@ static const char * const victus_thermal_profile_boards[] = {
 static const char * const victus_s_thermal_profile_boards[] = {
 	"8BBE", "8BD4", "8BD5",
 	"8C78", "8C99", "8C9C",
+	"8D41",
 };
 
 enum hp_wmi_radio {
-- 
2.51.2

Re: [PATCH v4] platform/x86: hp-wmi: Moved Omen MAX 16-ah0xx board name

[Ilpo Järvinen]

On Sat, 8 Nov 2025, Marcos Vega wrote:

> Fixed placement of board 8D41 so its categorized adequately in victus_s_thermal_profile_boards.

Thanks. I've applied this now to the review-ilpo-fixes branch.

I ended up fixing this changelog text myself by taking part of the text 
you had in v1.

--
 i.

> Signed-off-by: Marcos Vega <marcosmola2@gmail.com>
> ---
> Thank you for all the tips on proper kernel writing, I'll try to do it properly and learn for my next patch.
> 
> v4:
> - Added trailing comma

>  drivers/platform/x86/hp/hp-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index e10c75d91f24..ad9d9f97960f 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -96,6 +96,7 @@ static const char * const victus_thermal_profile_boards[] = {
>  static const char * const victus_s_thermal_profile_boards[] = {
>  	"8BBE", "8BD4", "8BD5",
>  	"8C78", "8C99", "8C9C",
> +	"8D41",
>  };
>  
>  enum hp_wmi_radio {
> 

-- 
 i.