Re: [PATCH v6 2/5] crypto: ccp - Declare PSP dead if PSP_CMD_TEE_RING_INIT fails

[Shyam Sundar S K <Shyam-sundar.S-k@amd.com>]

On 1/16/2026 09:41, Mario Limonciello (AMD) wrote:
> tee_init_ring() only declares PSP dead if the command times out.
> If there is any other failure it is still considered fatal though.
> Set psp_dead for other failures as well.
> 
> Fixes: 949a0c8dd3c2 ("crypto: ccp - Move direct access to some PSP registers out of TEE")
> Tested-by: Yijun Shen <Yijun.Shen@Dell.com>
> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>

Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

Thanks,
Shyam

> ---
>  drivers/crypto/ccp/tee-dev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/ccp/tee-dev.c b/drivers/crypto/ccp/tee-dev.c
> index 5e1d80724678d..af881daa5855b 100644
> --- a/drivers/crypto/ccp/tee-dev.c
> +++ b/drivers/crypto/ccp/tee-dev.c
> @@ -125,6 +125,7 @@ static int tee_init_ring(struct psp_tee_device *tee)
>  		dev_err(tee->dev, "tee: ring init command failed (%#010lx)\n",
>  			FIELD_GET(PSP_CMDRESP_STS, reg));
>  		tee_free_ring(tee);
> +		psp_dead = true;
>  		ret = -EIO;
>  	}
>