From: Takashi Iwai <tiwai@suse.de>
To: David Henningsson <david.henningsson@canonical.com>
Cc: alsa-devel@alsa-project.org, platform-driver-x86@vger.kernel.org,
ibm-acpi@hmh.eng.br, alex.hung@canonical.com,
hui.wang@canonical.com
Subject: Re: [PATCH v2 0/3] Enable mute LEDs and mic mute LEDs on Thinkpad
Date: Thu, 17 Oct 2013 12:08:46 +0200 [thread overview]
Message-ID: <s5h61swus41.wl%tiwai@suse.de> (raw)
In-Reply-To: <1381957833-13788-1-git-send-email-david.henningsson@canonical.com>
At Wed, 16 Oct 2013 23:10:30 +0200,
David Henningsson wrote:
>
> Encouraged by the quick and helpful feedback from both Takashi and Henrique (thanks!),
> I went to work with v2 of the patch.
>
> Changes since v1:
>
> - thinkpad-acpi patch: rewritten to follow Takashi's ideas
> - thinkpad-acpi patch: added documentation update
> - alsa side: added a separate patch for the new fixup action
> - alsa side: rewrote patch a little, mostly based on comments from Takashi
>
> David Henningsson (3):
> thinkpad-acpi: Add mute and mic-mute LED functionality
> ALSA: hda - add HDA_FIXUP_ACT_FREE action
> ALSA: hda - add connection to thinkpad_acpi to control mute/micmute
> LEDs
The new patches look OK to me. If Henrique agrees, I can apply all to
sound git tree.
thanks,
Takashi
>
> Documentation/laptops/thinkpad-acpi.txt | 7 ++-
> drivers/platform/x86/thinkpad_acpi.c | 92 ++++++++++++++++++++++++++++++-
> include/linux/thinkpad_acpi.h | 15 +++++
> sound/pci/hda/hda_local.h | 1 +
> sound/pci/hda/patch_conexant.c | 92 ++++++++++++++++++++++++++++++-
> 5 files changed, 202 insertions(+), 5 deletions(-)
> create mode 100644 include/linux/thinkpad_acpi.h
>
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-10-17 10:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 21:10 [PATCH v2 0/3] Enable mute LEDs and mic mute LEDs on Thinkpad David Henningsson
2013-10-16 21:10 ` [PATCH v2 1/3] thinkpad-acpi: Add mute and mic-mute LED functionality David Henningsson
2013-10-17 11:34 ` Henrique de Moraes Holschuh
2013-10-16 21:10 ` [PATCH v2 2/3] ALSA: hda - add HDA_FIXUP_ACT_FREE action David Henningsson
2013-10-16 21:10 ` [PATCH v2 3/3] ALSA: hda - add connection to thinkpad_acpi to control mute/micmute LEDs David Henningsson
2013-10-17 10:08 ` Takashi Iwai [this message]
2013-10-17 11:34 ` [PATCH v2 0/3] Enable mute LEDs and mic mute LEDs on Thinkpad Henrique de Moraes Holschuh
2013-10-17 13:15 ` Takashi Iwai
2013-10-17 16:16 ` David Henningsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h61swus41.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alex.hung@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=hui.wang@canonical.com \
--cc=ibm-acpi@hmh.eng.br \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox