From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46831C4346E for ; Tue, 29 Sep 2020 09:29:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC58C2076B for ; Tue, 29 Sep 2020 09:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727864AbgI2J3S (ORCPT ); Tue, 29 Sep 2020 05:29:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:42764 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbgI2J3S (ORCPT ); Tue, 29 Sep 2020 05:29:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 56C23AC6E; Tue, 29 Sep 2020 09:29:16 +0000 (UTC) Date: Tue, 29 Sep 2020 11:29:16 +0200 Message-ID: From: Takashi Iwai To: Hans de Goede Cc: Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Barnab1s PY1cze Subject: Re: Keyboard regression by intel-vbtn In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On Tue, 29 Sep 2020 11:21:27 +0200, Hans de Goede wrote: > > Hi, > > On 9/29/20 10:48 AM, Takashi Iwai wrote: > > Hi Hans, > > > > it seems that the recent update of intel-vtn broke the keyboard input > > on some laptops with libinput: > > https://bugzilla.opensuse.org/show_bug.cgi?id=1175599 > > > > Blacklisting intel-vtn fixes the issue, so it's likely the falsely > > reported tablet mode switch that leads libinput misbehaving. The > > affected machines are Acer E5-511 and ASUS X756UX laptops, and they > > shouldn't have the tablet mode at all, AFAIK. > > > > Could you take a look? I guess it's the commit cfae58ed681c that > > broke. The chassis type is Notebook on those, and this type should be > > excluded as well as Laptop. > > > > The dmidecode outputs and other info are found in the bugzilla above: > > https://bugzilla.opensuse.org/attachment.cgi?id=841999 > > https://bugzilla.opensuse.org/attachment.cgi?id=842039 > > > > The one for ASUS is embedded in hwinfo outpt: > > https://bugzilla.opensuse.org/attachment.cgi?id=841157 > > Ugh. What a mess, sorry about this. > > So as the commit message from commit cfae58ed681c > ("platform/x86: intel-vbtn: Only blacklist SW_TABLET_MODE on the 9 / "Laptop" chasis-type") > explains the reason to NOT NOT report SW_TABLET_MODE on devices > with a chassis type of 10 ("Notebook") is that at least > some HP ... 360 ... models use that chassis type and do > report a correct SW_TABLET_MODE through the intel-vbtn driver. > > The SW_TABLET_MODE on these actually got regressed by > de9647efeaa9 ("platform/x86: intel-vbtn: Only activate tablet mode switch on 2-in-1's") > which first introduced the chassis-type check. > > And to complicate things further even though some > HP ... 360 ... models use that chassis type and from the DSDT > it seems that they do report a correct SW_TABLET_MODE through the > intel-vbtn driver. In practice it is also broken on some > HP ... 360 ... models, see: > > https://forum.manjaro.org/t/keyboard-and-touchpad-only-work-on-kernel-5-6/22668 > http://git.infradead.org/linux-platform-drivers-x86.git/commit/d823346876a970522ff9e4d2b323c9b734dcc4de > "platform/x86: intel-vbtn: Fix SW_TABLET_MODE always reporting 1 on the HP Pavilion 11 x360" Oohoo, what a wonderful world :) > Since the problem of wrongly reporting SW_TABLET_MODE=1 in combination > with libinput, leads to a non-usable system. Where as OTOH many people will > not even notice when SW_TABLET_MODE is not being reported, I believe it > is best to move to a dmi based allow-list approach here, as we recently > did for SW_TABLET_MODE reporting by the asus-wmi driver. Allowing: > > dmi chassis-types: 8 /* Portable */, 31 /* Convertible */, 32 /* Detachable */ > and the HP Stream x360 11-p000nd which has working intel-vbtn SW_TABLET_MODE > support combined with a chassis-type of 10 /* Notebook */. > > I will prepare a patch for this right away. Great, thanks! I'll build a test kernel when receiving a patch soon. Takashi > Note this patch will effectively replace: > "platform/x86: intel-vbtn: Fix SW_TABLET_MODE always reporting 1 on the HP Pavilion 11 x360" > We will no longer need this workaround with the allow list and I believe > that it would be better to drop that one. > > Andy can you drop that one from your review-andy branch please? > > Regards, > > Hans > >