From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED
Date: Tue, 20 Nov 2018 10:23:25 +0100
Message-ID: <s5hbm6kf6gi.wl-tiwai@suse.de>
References: <20181108171701.4444-1-ayman.bagabas@gmail.com>
        <20181108171701.4444-4-ayman.bagabas@gmail.com>
        <20181119235713.GB7367@amd>
        <s5hr2fgfcrm.wl-tiwai@suse.de>
        <20181120091039.GA16916@amd>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20181120091039.GA16916@amd>
Sender: linux-kernel-owner@vger.kernel.org
To: Pavel Machek <pavel@ucw.cz>
Cc: Ayman Bagabas <ayman.bagabas@gmail.com>, alsa-devel@alsa-project.org, Hui Wang <hui.wang@canonical.com>, Andy Shevchenko <andy@infradead.org>, Darren Hart <dvhart@infradead.org>, Jaroslav Kysela <perex@perex.cz>, Kailang Yang <kailang@realtek.com>, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
List-Id: platform-driver-x86.vger.kernel.org

On Tue, 20 Nov 2018 10:10:39 +0100,
Pavel Machek wrote:
> 
> On Tue 2018-11-20 08:07:09, Takashi Iwai wrote:
> > On Tue, 20 Nov 2018 00:57:13 +0100,
> > Pavel Machek wrote:
> > > 
> > > > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
> > > > +#include <linux/platform_data/x86/huawei_wmi.h>
> > > > +
> > > > +static int (*huawei_wmi_micmute_led_set_func)(bool);
> > > > +
> > > 
> > > So we should not be doing this.
> > > 
> > > Thinkpad ACPI module exports its LEDs there, for example.
> > 
> > Both thinkpad_acpi and dell_laptop provide the interface to HD-audio
> > in the very same way like this.
> 
> Not good :-(. Please don't add new ones, general purpose LEDs should
> really use LED subsystem.

What's the problem with this approach?


Takashi