From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v4] ACPI / video: Add systems that should favour native backlight interface Date: Tue, 18 Feb 2014 14:31:46 +0100 Message-ID: References: <5302F58C.1080001@intel.com> <20140218103442.GS5018@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20140218103442.GS5018@intel.com> Sender: linux-acpi-owner@vger.kernel.org To: Mika Westerberg Cc: Aaron Lu , "Rafael J. Wysocki" , Igor Gnatenko , Theodore Tso , Peter Weber , Lennart Poettering , Kevin Smith , Rinat Ibragimov , sov.info@mail.ru, Thomas Christensen , Vladimir Sherenkov , ACPI Devel Mailing List , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , Matthew Garrett , Daniel Vetter , Jani Nikula , "intel-gfx@lists.freedesktop.org" List-Id: platform-driver-x86.vger.kernel.org At Tue, 18 Feb 2014 12:34:42 +0200, Mika Westerberg wrote: > > On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote: > > + { > > + .callback = video_set_use_native_backlight, > > + .ident = "HP EliteBook 2013 models", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "), > > + DMI_MATCH(DMI_PRODUCT_NAME, " G1"), > > + }, > > + }, > > I see my device is listed here but the above doesn't really use native > backlight because it is still in acpi_osi blacklist. Tried this and I can > see both acpi_video0 and intel_backlight listed under /sys/class/backlight. > Was this the intention? The acpi_osi blacklist commit (2d4054d84224) has to be reverted, as I mentioned earlier. But the revert can be done individually after merging this patch. Rafael, could you care? Takashi